Lyude Paul 319e53f155 drm/panic: Fix uninitialized spinlock acquisition with CONFIG_DRM_PANIC=n ... It turns out that if you happen to have a kernel config where CONFIG_DRM_PANIC is disabled and spinlock debugging is enabled, along with KMS being enabled - we'll end up trying to acquire an uninitialized spin_lock with drm_panic_lock() when we try to do a commit: rvkms rvkms.0: [drm:drm_atomic_commit] committing 0000000068d2ade1 INFO: trying to register non-static key. The code is fine but needs lockdep annotation, or maybe you didn't initialize this object before use? turning off the locking correctness validator. CPU: 4 PID: 1347 Comm: modprobe Not tainted 6.10.0-rc1Lyude-Test+ #272 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS edk2-20240524-3.fc40 05/24/2024 Call Trace: <TASK> dump_stack_lvl+0x77/0xa0 assign_lock_key+0x114/0x120 register_lock_class+0xa8/0x2c0 __lock_acquire+0x7d/0x2bd0 ? __vmap_pages_range_noflush+0x3a8/0x550 ? drm_atomic_helper_swap_state+0x2ad/0x3a0 lock_acquire+0xec/0x290 ? drm_atomic_helper_swap_state+0x2ad/0x3a0 ? lock_release+0xee/0x310 _raw_spin_lock_irqsave+0x4e/0x70 ? drm_atomic_helper_swap_state+0x2ad/0x3a0 drm_atomic_helper_swap_state+0x2ad/0x3a0 drm_atomic_helper_commit+0xb1/0x270 drm_atomic_commit+0xaf/0xe0 ? __pfx___drm_printfn_info+0x10/0x10 drm_client_modeset_commit_atomic+0x1a1/0x250 drm_client_modeset_commit_locked+0x4b/0x180 drm_client_modeset_commit+0x27/0x50 __drm_fb_helper_restore_fbdev_mode_unlocked+0x76/0x90 drm_fb_helper_set_par+0x38/0x40 fbcon_init+0x3c4/0x690 visual_init+0xc0/0x120 do_bind_con_driver+0x409/0x4c0 do_take_over_console+0x233/0x280 do_fb_registered+0x11f/0x210 fbcon_fb_registered+0x2c/0x60 register_framebuffer+0x248/0x2a0 __drm_fb_helper_initial_config_and_unlock+0x58a/0x720 drm_fbdev_generic_client_hotplug+0x6e/0xb0 drm_client_register+0x76/0xc0 _RNvXs_CsHeezP08sTT_5rvkmsNtB4_5RvkmsNtNtCs1cdwasc6FUb_6kernel8platform6Driver5probe+0xed2/0x1060 [rvkms] ? _RNvMs_NtCs1cdwasc6FUb_6kernel8platformINtB4_7AdapterNtCsHeezP08sTT_5rvkms5RvkmsE14probe_callbackBQ_+0x2b/0x70 [rvkms] ? acpi_dev_pm_attach+0x25/0x110 ? platform_probe+0x6a/0xa0 ? really_probe+0x10b/0x400 ? __driver_probe_device+0x7c/0x140 ? driver_probe_device+0x22/0x1b0 ? __device_attach_driver+0x13a/0x1c0 ? __pfx___device_attach_driver+0x10/0x10 ? bus_for_each_drv+0x114/0x170 ? __device_attach+0xd6/0x1b0 ? bus_probe_device+0x9e/0x120 ? device_add+0x288/0x4b0 ? platform_device_add+0x75/0x230 ? platform_device_register_full+0x141/0x180 ? rust_helper_platform_device_register_simple+0x85/0xb0 ? _RNvMs2_NtCs1cdwasc6FUb_6kernel8platformNtB5_6Device13create_simple+0x1d/0x60 ? _RNvXs0_CsHeezP08sTT_5rvkmsNtB5_5RvkmsNtCs1cdwasc6FUb_6kernel6Module4init+0x11e/0x160 [rvkms] ? 0xffffffffc083f000 ? init_module+0x20/0x1000 [rvkms] ? kernfs_xattr_get+0x3e/0x80 ? do_one_initcall+0x148/0x3f0 ? __lock_acquire+0x5ef/0x2bd0 ? __lock_acquire+0x5ef/0x2bd0 ? __lock_acquire+0x5ef/0x2bd0 ? put_cpu_partial+0x51/0x1d0 ? lock_acquire+0xec/0x290 ? put_cpu_partial+0x51/0x1d0 ? lock_release+0xee/0x310 ? put_cpu_partial+0x51/0x1d0 ? fs_reclaim_acquire+0x69/0xf0 ? lock_acquire+0xec/0x290 ? fs_reclaim_acquire+0x69/0xf0 ? kfree+0x22f/0x340 ? lock_release+0xee/0x310 ? kmalloc_trace_noprof+0x48/0x340 ? do_init_module+0x22/0x240 ? kmalloc_trace_noprof+0x155/0x340 ? do_init_module+0x60/0x240 ? __se_sys_finit_module+0x2e0/0x3f0 ? do_syscall_64+0xa4/0x180 ? syscall_exit_to_user_mode+0x108/0x140 ? do_syscall_64+0xb0/0x180 ? vma_end_read+0xd0/0xe0 ? do_user_addr_fault+0x309/0x640 ? clear_bhb_loop+0x45/0xa0 ? clear_bhb_loop+0x45/0xa0 ? clear_bhb_loop+0x45/0xa0 ? entry_SYSCALL_64_after_hwframe+0x76/0x7e </TASK> Fix this by stubbing these macros out when this config option isn't enabled, along with fixing the unused variable warning that introduces. Signed-off-by: Lyude Paul <lyude@redhat.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Fixes: e2a1cda3e0 ("drm/panic: Add drm panic locking") Cc: <stable@vger.kernel.org> # v6.10+ Link: https://patchwork.freedesktop.org/patch/msgid/20240916230103.611490-1-lyude@redhat.com		2024-09-16 19:03:29 -04:00
..
bridge	drm/imx: add internal bridge handling display-timings DT node	2024-09-03 02:35:35 +03:00
display	drm-misc-next for v6.12:	2024-08-30 13:40:38 +10:00
i2c	drm/i2c: silence ch7006.h and sil164.h kernel-doc warnings	2024-03-11 14:29:19 +02:00
intel	drm/i915: ARL requires a newer GSC firmware	2024-08-27 13:23:58 +03:00
ttm	Linux 6.11-rc7	2024-09-11 09:18:15 +02:00
amd_asic_type.h	drm/amdgpu: make amd_asic_type.h self-contained	2024-03-07 17:17:25 +02:00
drm_accel.h	accel: Use XArray instead of IDR for minors	2024-08-26 17:06:22 +02:00
drm_aperture.h	drm/aperture: Remove primary argument	2023-04-16 14:17:41 +02:00
drm_atomic.h	drm/atomic: fix kerneldoc for fake_commit field	2024-08-26 16:28:48 +02:00
drm_atomic_helper.h	drm-misc-next for $kernel-version:	2023-12-19 17:07:32 +10:00
drm_atomic_state_helper.h	drm/atomic-helper: Add an analog TV atomic_check implementation	2022-11-24 12:42:40 +01:00
drm_atomic_uapi.h	…
drm_audio_component.h	drm/audio: make drm_audio_component.h self-contained	2022-11-29 14:14:51 +02:00
drm_auth.h	drm: Remove source code for non-KMS drivers	2023-12-06 10:08:37 +01:00
drm_blend.h	Revert "drm: Introduce pixel_source DRM plane property"	2023-12-04 21:33:10 +02:00
drm_bridge.h	drm/bridge-connector: implement glue code for HDMI connector	2024-06-12 10:56:57 +03:00
drm_bridge_connector.h	drm/bridge_connector: drop drm_bridge_connector_en/disable_hpd()	2023-01-05 15:08:10 +01:00
drm_buddy.h	drm/buddy: Add start address support to trim function	2024-08-07 18:19:00 -04:00
drm_cache.h	…
drm_client.h	drm/fbdev-generic: Fix locking with drm_client_buffer_vmap_local()	2024-03-11 13:33:50 +01:00
drm_color_mgmt.h	drm: using mul_u32_u32() requires linux/math64.h	2023-12-19 15:29:17 +02:00
drm_connector.h	Revert "drm: Introduce 'power saving policy' drm property"	2024-08-02 11:28:53 -04:00
drm_crtc.h	drm: Remove references to removed transitional helpers	2023-07-29 21:25:16 +02:00
drm_crtc_helper.h	drm/crtc-helper: Remove most include statements from drm_crtc_helper.h	2023-01-18 09:25:32 +01:00
drm_damage_helper.h	…
drm_debugfs.h	drm/gpuvm: rename struct drm_gpuva_manager to struct drm_gpuvm	2023-09-26 01:51:28 +02:00
drm_debugfs_crc.h	drm/crc: make drm_debugfs_crc.h self-contained and fix kernel-doc	2024-03-07 17:17:25 +02:00
drm_device.h	drm/vblank: add dynamic per-crtc vblank configuration support	2024-07-26 17:40:10 -04:00
drm_drv.h	drm: Remove struct drm_driver.lastclose	2024-08-13 16:21:12 +02:00
drm_edid.h	drm/edid: make drm_edid_block_valid() static	2024-08-14 12:16:34 +03:00
drm_eld.h	drm/eld: add helpers to modify the SADs of an ELD	2023-11-09 16:48:27 +02:00
drm_encoder.h	drm/encoder: register per-encoder debugfs dir	2023-12-04 16:07:29 +02:00
drm_encoder_slave.h	drm/encoder: improve drm_encoder_slave.h kernel-doc	2024-03-11 11:47:06 +02:00
drm_exec.h	Merge drm/drm-next into drm-misc-next	2024-01-29 14:20:23 +01:00
drm_fb_dma_helper.h	drm/fb_dma: s/drm_panic_gem_get_scanout_buffer/drm_fb_dma_get_scanout_buffer	2024-04-15 13:50:40 -03:00
drm_fb_helper.h	drm/fbdev-helper: Remove drm_fb_helper_output_poll_changed()	2024-08-13 16:21:11 +02:00
drm_fbdev_dma.h	drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers	2023-03-14 17:07:47 +01:00
drm_fbdev_shmem.h	drm/fbdev: Add fbdev-shmem	2024-05-02 11:33:15 +02:00
drm_fbdev_ttm.h	drm/fbdev-generic: Convert to fbdev-ttm	2024-05-02 11:33:32 +02:00
drm_file.h	accel: Use XArray instead of IDR for minors	2024-08-26 17:06:22 +02:00
drm_fixed.h	drm: fixed: Don't use "proxy" headers	2024-08-13 12:13:45 +03:00
drm_flip_work.h	drm: Fix flip-task docs	2023-11-14 10:23:12 +01:00
drm_format_helper.h	drm: fix drm_format_helper.h kernel-doc warnings	2024-03-07 17:17:25 +02:00
drm_fourcc.h	drm: Remove plane hsub/vsub alignment requirement for core helpers	2023-10-12 09:51:19 +02:00
drm_framebuffer.h	drm: Remove legacy cursor hotspot code	2023-11-24 11:58:02 +01:00
drm_gem.h	drm/fbdev-generic: Fix locking with drm_client_buffer_vmap_local()	2024-03-11 13:33:50 +01:00
drm_gem_atomic_helper.h	drm/atomic-helper: Add format-conversion state to shadow-plane state	2023-11-14 10:01:14 +01:00
drm_gem_dma_helper.h	drm: Clear fd/handle callbacks in struct drm_driver	2023-06-26 11:08:41 +02:00
drm_gem_framebuffer_helper.h	…
drm_gem_shmem_helper.h	drm/gem: Acquire reservation lock in drm_gem_{pin/unpin}()	2024-03-11 13:33:50 +01:00
drm_gem_ttm_helper.h	drm/ttm: merge ttm_bo_api.h and ttm_bo_driver.h v2	2022-12-06 12:54:14 +01:00
drm_gem_vram_helper.h	drm/gem-vram: Remove support for simple display pipelines	2024-09-06 14:41:38 +02:00
drm_gpuvm.h	Merge drm/drm-next into drm-misc-next	2024-01-29 14:20:23 +01:00
drm_ioctl.h	drm: Remove locking for legacy ioctls and DRM_UNLOCKED	2023-12-06 10:08:32 +01:00
drm_kunit_helpers.h	drm/kunit: fix drm_kunit_helpers.h kernel-doc	2024-03-07 17:17:25 +02:00
drm_lease.h	drm/lease: make drm_lease.h self-contained	2024-03-07 17:17:25 +02:00
drm_managed.h	drm/managed: Add drmm_release_action	2024-01-17 10:38:39 +01:00
drm_mipi_dbi.h	drm/mipi-dbi: Add support for DRM_FORMAT_RGB888	2024-06-07 16:09:05 +02:00
drm_mipi_dsi.h	drm/mipi-dsi: Add mipi_dsi_dcs_set_tear_scanline_multi	2024-08-20 14:17:54 -07:00
drm_mm.h	drm/mm: Remove unused drm_mm_replace_node	2024-06-06 10:24:13 -04:00
drm_mode_config.h	drm: Remove struct drm_mode_config_funcs.output_poll_changed	2024-08-13 16:21:13 +02:00
drm_mode_object.h	drm/drm_mode_object: increase max objects to accommodate new color props	2023-12-13 15:09:53 -05:00
drm_modes.h	drm: Move drm_set_preferred_mode() helper from drm_edid to drm_modes	2024-01-05 21:14:46 +01:00
drm_modeset_helper.h	…
drm_modeset_helper_vtables.h	drm/panic: Add a drm panic handler	2024-04-15 16:12:49 +02:00
drm_modeset_lock.h	…
drm_module.h	…
drm_of.h	drm/of: make drm_of.h self-contained	2024-03-07 17:17:25 +02:00
drm_panel.h	drm/panel: Fix kernel-doc typo for `follower_lock`	2023-08-03 10:21:27 +02:00
drm_panic.h	drm/panic: Fix uninitialized spinlock acquisition with CONFIG_DRM_PANIC=n	2024-09-16 19:03:29 -04:00
drm_pciids.h	drm: Remove some obsolete drm pciids(tdfx, mga, i810, savage, r128, sis, via)	2023-01-13 09:44:56 +01:00
drm_plane.h	drm: Export drm_plane_has_format()	2024-06-24 17:08:53 +03:00
drm_plane_helper.h	drm/plane-helper: Move drm_plane_helper_atomic_check() into udl	2023-12-06 10:35:49 +01:00
drm_prime.h	Revert "drm/prime: Unexport helpers for fd/handle conversion"	2023-11-30 14:46:04 -05:00
drm_print.h	drm/printer: Allow NULL data in devcoredump printer	2024-08-01 11:00:12 -07:00
drm_privacy_screen_consumer.h	…
drm_privacy_screen_driver.h	…
drm_privacy_screen_machine.h	…
drm_probe_helper.h	drm/ast: Automatically clean up poll helper	2024-04-02 10:40:52 +02:00
drm_property.h	drm/drm_property: make replace_property_blob_from_id a DRM helper	2023-12-13 15:09:53 -05:00
drm_rect.h	drm/rect: Add drm_rect_overlap()	2024-08-23 16:47:56 +02:00
drm_self_refresh_helper.h	…
drm_simple_kms_helper.h	drm/simple-kms: Remove drm_gem_simple_display_pipe_prepare_fb()	2022-12-05 13:35:37 +01:00
drm_suballoc.h	drm/suballoc: fix drm_suballoc.h kernel-doc	2024-03-07 17:17:25 +02:00
drm_syncobj.h	drm/syncobj: add IOCTL to register an eventfd	2023-07-20 12:01:03 +02:00
drm_sysfs.h	drm/sysfs: rename drm_sysfs_connector_status_event()	2023-06-23 15:54:00 +02:00
drm_util.h	…
drm_utils.h	…
drm_vblank.h	drm/vblank: add dynamic per-crtc vblank configuration support	2024-07-26 17:40:10 -04:00
drm_vblank_work.h	drm: Add drm_vblank_work_flush_all().	2024-06-24 18:03:18 +02:00
drm_vma_manager.h	drm/drm_vma_manager: Add drm_vma_node_allow_once()	2023-01-19 14:16:55 +01:00
drm_writeback.h	…
gpu_scheduler.h	drm/sched: add optional errno to drm_sched_start()	2024-09-06 18:05:52 +02:00
gud.h	…
spsc_queue.h	…
task_barrier.h	drm: Spelling s/randevouz/rendez-vous/	2023-07-29 21:11:54 +02:00