Íñigo Huguet f94becae90 ptp: vclock: use mutex to fix "sleep on atomic" bug ... [ Upstream commit 67d93ffc0f ] vclocks were using spinlocks to protect access to its timecounter and cyclecounter. Access to timecounter/cyclecounter is backed by the same driver callbacks that are used for non-virtual PHCs, but the usage of the spinlock imposes a new limitation that didn't exist previously: now they're called in atomic context so they mustn't sleep. Some drivers like sfc or ice may sleep on these callbacks, causing errors like "BUG: scheduling while atomic: ptp5/25223/0x00000002" Fix it replacing the vclock's spinlock by a mutex. It fix the mentioned bug and it doesn't introduce longer delays. I've tested synchronizing various different combinations of clocks: - vclock->sysclock - sysclock->vclock - vclock->vclock - hardware PHC in different NIC -> vclock - created 4 vclocks and launch 4 parallel phc2sys processes with lockdep enabled In all cases, comparing the delays reported by phc2sys, they are in the same range of values than before applying the patch. Link: https://lore.kernel.org/netdev/69d0ff33-bd32-6aa5-d36c-fbdc3c01337c@redhat.com/ Fixes: 5d43f951b1 ("ptp: add ptp virtual clock driver framework") Reported-by: Yalin Li <yalli@redhat.com> Suggested-by: Richard Cochran <richardcochran@gmail.com> Tested-by: Miroslav Lichvar <mlichvar@redhat.com> Signed-off-by: Íñigo Huguet <ihuguet@redhat.com> Acked-by: Richard Cochran <richardcochran@gmail.com> Link: https://lore.kernel.org/r/20230221130616.21837-1-ihuguet@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-03-11 13:55:25 +01:00
..
Kconfig	ptp: ocp: Select CRC16 in the Kconfig.	2022-07-27 18:11:34 -07:00
Makefile	…
ptp_chardev.c	…
ptp_clock.c	ptp: Remove usage of the deprecated ida_simple_xxx API	2022-09-27 17:33:11 -07:00
ptp_clockmatrix.c	ptp: ptp_clockmatrix: fix is_single_shot	2022-05-25 21:51:32 -07:00
ptp_clockmatrix.h	ptp: ptp_clockmatrix: return -EBUSY if phase pull-in is in progress	2022-05-17 17:49:04 -07:00
ptp_dte.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - gpl-2.0_30.RULE (part 2)	2022-06-10 14:51:35 +02:00
ptp_idt82p33.c	ptp: idt82p33: use rsmu driver to access i2c/spi bus	2022-03-09 19:50:57 -08:00
ptp_idt82p33.h	ptp: idt82p33: use rsmu driver to access i2c/spi bus	2022-03-09 19:50:57 -08:00
ptp_ines.c	…
ptp_kvm_arm.c	…
ptp_kvm_common.c	…
ptp_kvm_x86.c	…
ptp_ocp.c	] ptp: ocp: remove symlink for second GNSS	2022-10-10 08:37:24 +01:00
ptp_pch.c	ptp_pch: Remove unused pch_pm_ops	2022-02-08 21:04:32 -08:00
ptp_private.h	ptp: vclock: use mutex to fix "sleep on atomic" bug	2023-03-11 13:55:25 +01:00
ptp_qoriq.c	…
ptp_qoriq_debugfs.c	…
ptp_sysfs.c	ptp: Add cycles support for virtual clocks	2022-05-10 09:48:08 +02:00
ptp_vclock.c	ptp: vclock: use mutex to fix "sleep on atomic" bug	2023-03-11 13:55:25 +01:00
ptp_vmw.c	…