ca39500f6a
Sysfs interface for updating firmware for RMI devices is available even
when F34 probe fails. The code checks for presence of F34 "container"
pointer and then tries to use the function data attached to the
sub-device. F34 assigns the function data early, before it knows if
probe will succeed, leaving behind a stale pointer.
Fix this by expanding checks to not only test for presence of F34
"container" but also check if there is driver data assigned to the
sub-device, and call dev_set_drvdata() only after we are certain that
probe is successful.
This is not a complete fix, since F34 will be freed during firmware
update, so there is still a race when fetching and accessing this
pointer. This race will be addressed in follow-up changes.
Reported-by: Hanno Böck <hanno@hboeck.de>
Fixes:
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| rmi_2d_sensor.c | ||
| rmi_2d_sensor.h | ||
| rmi_bus.c | ||
| rmi_bus.h | ||
| rmi_driver.c | ||
| rmi_driver.h | ||
| rmi_f01.c | ||
| rmi_f03.c | ||
| rmi_f3a.c | ||
| rmi_f11.c | ||
| rmi_f12.c | ||
| rmi_f30.c | ||
| rmi_f34.c | ||
| rmi_f34.h | ||
| rmi_f34v7.c | ||
| rmi_f54.c | ||
| rmi_f55.c | ||
| rmi_i2c.c | ||
| rmi_smbus.c | ||
| rmi_spi.c | ||