Jakub Kicinski 374d345d9b netlink: add variable-length / auto integers ... We currently push everyone to use padding to align 64b values in netlink. Un-padded nla_put_u64() doesn't even exist any more. The story behind this possibly start with this thread: https://lore.kernel.org/netdev/20121204.130914.1457976839967676240.davem@davemloft.net/ where DaveM was concerned about the alignment of a structure containing 64b stats. If user space tries to access such struct directly: struct some_stats *stats = nla_data(attr); printf("A: %llu", stats->a); lack of alignment may become problematic for some architectures. These days we most often put every single member in a separate attribute, meaning that the code above would use a helper like nla_get_u64(), which can deal with alignment internally. Even for arches which don't have good unaligned access - access aligned to 4B should be pretty efficient. Kernel and well known libraries deal with unaligned input already. Padded 64b is quite space-inefficient (64b + pad means at worst 16B per attr vs 32b which takes 8B). It is also more typing: if (nla_put_u64_pad(rsp, NETDEV_A_SOMETHING_SOMETHING, value, NETDEV_A_SOMETHING_PAD)) Create a new attribute type which will use 32 bits at netlink level if value is small enough (probably most of the time?), and (4B-aligned) 64 bits otherwise. Kernel API is just: if (nla_put_uint(rsp, NETDEV_A_SOMETHING_SOMETHING, value)) Calling this new type "just" sint / uint with no specific size will hopefully also make people more comfortable with using it. Currently telling people "don't use u8, you may need the bits, and netlink will round up to 4B, anyway" is the #1 comment we give to newcomers. In terms of netlink layout it looks like this: 0 4 8 12 16 32b: [nlattr][ u32 ] 64b: [ pad ][nlattr][ u64 ] uint(32) [nlattr][ u32 ] uint(64) [nlattr][ u64 ] Signed-off-by: Jakub Kicinski <kuba@kernel.org> Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2023-10-20 11:43:35 +01:00
..
9p	9p: Add additional debug flags and open modes	2023-03-27 02:33:48 +00:00
bluetooth	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-10-19 13:29:01 -07:00
caif	net: caif: Remove unused declaration cfsrvl_ctrlcmd()	2023-08-10 18:24:48 -07:00
iucv	…
mana	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-10-05 13:16:47 -07:00
netfilter	netfilter: nf_tables: de-constify set commit ops function argument	2023-10-18 10:26:43 +02:00
netns	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-10-19 13:29:01 -07:00
nfc	…
page_pool	page_pool: fragment API support for 32-bit arch with 64-bit DMA	2023-10-16 18:28:59 -07:00
phonet	net: ioctl: Use kernel memory on protocol ioctl callbacks	2023-06-15 22:33:26 -07:00
sctp	sctp: Remove unused declaration sctp_backlog_migrate()	2023-08-10 19:31:52 -07:00
tc_act	net/sched: act_connmark: transition to percpu stats and rcu	2023-02-16 10:39:28 +01:00
6lowpan.h	…
Space.h	net: appletalk: remove cops support	2023-10-04 11:49:20 -07:00
act_api.h	net/sched: Rename user cookie and act cookie	2023-02-20 16:46:10 -08:00
addrconf.h	ipv6: constify inet6_mc_check()	2023-03-17 08:56:37 +00:00
af_ieee802154.h	…
af_rxrpc.h	rxrpc: Fix timeout of a call that hasn't yet been granted a channel	2023-05-01 07:43:19 +01:00
af_unix.h	af_unix: preserve const qualifier in unix_sk()	2023-03-18 12:23:33 +00:00
af_vsock.h	vsock: check for MSG_ZEROCOPY support on send	2023-10-15 13:19:42 +01:00
ah.h	…
amt.h	…
arp.h	neighbour: switch to standard rcu, instead of rcu_bh	2023-03-21 21:32:18 -07:00
atmclip.h	…
ax25.h	x25: preserve const qualifier in [a]x25_sk()	2023-03-18 12:23:34 +00:00
ax88796.h	…
bareudp.h	…
bond_3ad.h	bonding: 3ad: Remove unused declaration bond_3ad_update_lacp_active()	2023-07-28 18:06:30 -07:00
bond_alb.h	bonding (gcc13): synchronize bond_{a,t}lb_xmit() types	2022-11-02 20:38:13 -07:00
bond_options.h	…
bonding.h	bonding: fix macvlan over alb bond support	2023-08-24 10:07:13 +02:00
bpf_sk_storage.h	…
busy_poll.h	net: invert the netdevice.h vs xdp.h dependency	2023-08-03 08:38:07 -07:00
calipso.h	…
cfg80211-wext.h	wifi: cfg80211: Avoid clashing function prototypes	2022-11-16 11:31:47 +02:00
cfg80211.h	Merge wireless into wireless-next	2023-10-06 17:08:47 +03:00
cfg802154.h	net: cfg802154: fix kernel-doc notation warnings	2023-07-14 20:39:29 -07:00
checksum.h	net: checksum: drop the linux/uaccess.h include	2023-01-27 11:19:46 +00:00
cipso_ipv4.h	…
cls_cgroup.h	…
codel.h	codel: fix kernel-doc notation warnings	2023-07-14 20:39:29 -07:00
codel_impl.h	…
codel_qdisc.h	…
compat.h	…
datalink.h	net: datalink: Remove unused declarations	2023-07-27 17:17:32 -07:00
dcbevent.h	…
dcbnl.h	net: dcb: add helper functions to retrieve PCP and DSCP rewrite maps	2023-01-20 09:33:22 +00:00
devlink.h	devlink: convert most of devlink_fmsg_*() to return void	2023-10-20 11:34:51 +01:00
dropreason-core.h	net, sched: Add tcf_set_drop_reason for {__,}tcf_classify	2023-10-16 10:07:37 -07:00
dropreason.h	net: openvswitch: add last-action drop reason	2023-08-14 08:01:06 +01:00
dsa.h	net: dsa: notify drivers of MAC address changes on user ports	2023-10-03 13:51:02 +02:00
dsa_stubs.h	net: dsa: replace NETDEV_PRE_CHANGE_HWTSTAMP notifier with a stub	2023-04-09 15:35:49 +01:00
dsfield.h	…
dst.h	net: dst: remove unnecessary input parameter in dst_alloc and dst_init	2023-09-12 11:42:25 +02:00
dst_cache.h	…
dst_metadata.h	xfrm: interface: Add unstable helpers for setting/getting XFRM metadata from TC-BPF	2022-12-05 21:58:27 -08:00
dst_ops.h	net: remove unnecessary input parameter 'how' in ifdown function	2023-08-22 13:19:02 +02:00
erspan.h	…
esp.h	…
espintcp.h	…
ethoc.h	…
failover.h	…
fib_notifier.h	…
fib_rules.h	…
firewire.h	…
flow.h	ipv4: Drop tos parameter from flowi4_update_output()	2023-06-02 10:52:38 +01:00
flow_dissector.h	net: flow_dissector: Add IPSEC dissector	2023-08-02 10:09:31 +01:00
flow_offload.h	flow_offload: Annotate struct flow_action_entry with __counted_by	2023-10-06 11:37:02 +01:00
fou.h	bpf,fou: Add bpf_skb_{set,get}_fou_encap kfuncs	2023-04-12 16:40:39 -07:00
fq.h	net: fq: Remove unused typedef fq_flow_get_default_t	2023-08-08 15:58:23 -07:00
fq_impl.h	wifi: mac80211: add support for restricting netdev features per vif	2022-12-01 15:09:10 +01:00
garp.h	…
gen_stats.h	…
genetlink.h	genetlink: add genlmsg_iput() API	2023-08-15 15:01:03 -07:00
geneve.h	net: geneve: fix array of flexible structures warnings	2022-10-31 10:43:04 +00:00
gre.h	…
gro.h	net: gro: fix misuse of CB in udp socket lookup	2023-07-29 17:10:27 +01:00
gro_cells.h	…
gso.h	net: move gso declarations and functions to their own files	2023-06-10 00:11:41 -07:00
gtp.h	…
gue.h	…
handshake.h	net/handshake: Add helpers for parsing incoming TLS Alerts	2023-07-28 14:07:59 -07:00
hwbm.h	…
icmp.h	…
ieee80211_radiotap.h	wifi: radiotap: add bandwidth definition of EHT U-SIG	2023-10-12 15:14:27 +03:00
ieee802154_netdev.h	mac802154: Handle received BEACON_REQ	2023-03-23 21:51:30 +01:00
if_inet6.h	ipv6: Annotate struct ip6_sf_socklist with __counted_by	2023-10-02 11:24:52 -07:00
ife.h	…
inet6_connection_sock.h	…
inet6_hashtables.h	net: Fix slab-out-of-bounds in inet[6]_steal_sock	2023-08-15 13:57:51 -07:00
inet_common.h	net: factor out __inet_listen_sk() helper	2023-08-14 07:06:13 +01:00
inet_connection_sock.h	tcp: Set pingpong threshold via sysctl	2023-10-16 14:55:32 -07:00
inet_dscp.h	…
inet_ecn.h	…
inet_frag.h	inet: frags: eliminate kernel-doc warning	2023-07-14 20:39:29 -07:00
inet_hashtables.h	net: Fix slab-out-of-bounds in inet[6]_steal_sock	2023-08-15 13:57:51 -07:00
inet_sock.h	ipv6: lockless IPV6_FLOWINFO_SEND implementation	2023-09-15 10:33:48 +01:00
inet_timewait_sock.h	tcp: Add TIME_WAIT sockets in bhash2.	2022-12-30 07:25:52 +00:00
inetpeer.h	…
ioam6.h	…
ip.h	inet: lock the socket in ip_sock_set_tos()	2023-10-19 13:13:13 +02:00
ip6_checksum.h	…
ip6_fib.h	net: fib: avoid warn splat in flow dissector	2023-08-31 12:33:03 +02:00
ip6_route.h	ipv6: lockless IPV6_ADDR_PREFERENCES implementation	2023-09-19 18:21:44 +02:00
ip6_tunnel.h	…
ip_fib.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-10-05 13:16:47 -07:00
ip_tunnels.h	ip_tunnels: use DEV_STATS_INC()	2023-09-06 06:05:59 +01:00
ip_vs.h	ipvs: Correct spelling in comments	2023-04-22 01:39:41 +02:00
ipcomp.h	xfrm: ipcomp: add extack to ipcomp{4,6}_init_state	2022-09-29 07:18:00 +02:00
ipconfig.h	…
ipv6.h	ipv6: lockless IPV6_ADDR_PREFERENCES implementation	2023-09-19 18:21:44 +02:00
ipv6_frag.h	net: dropreason: add SKB_DROP_REASON_FRAG_REASM_TIMEOUT	2022-10-31 20:14:27 -07:00
ipv6_stubs.h	bpf: Derive source IP addr via bpf_*_fib_lookup()	2023-10-09 16:28:35 -07:00
iw_handler.h	wifi: wext: Remove unused declaration dev_get_wireless_info()	2023-08-22 21:40:40 +02:00
kcm.h	kcm: Send multiple frags in one sendmsg()	2023-06-12 21:13:23 -07:00
l3mdev.h	…
lag.h	…
lapb.h	…
lib80211.h	…
llc.h	…
llc_c_ac.h	net: llc: Remove unused function declarations	2023-08-04 15:33:17 -07:00
llc_c_ev.h	net: llc: Remove unused function declarations	2023-08-04 15:33:17 -07:00
llc_c_st.h	…
llc_conn.h	llc: Check netns in llc_estab_match() and llc_listener_match().	2023-07-20 10:46:28 +02:00
llc_if.h	…
llc_pdu.h	net: llc: fix kernel-doc notation warnings	2023-07-14 20:39:29 -07:00
llc_s_ac.h	…
llc_s_ev.h	…
llc_s_st.h	…
llc_sap.h	…
lwtunnel.h	lwt: Check LWTUNNEL_XMIT_CONTINUE strictly	2023-08-18 16:05:26 +02:00
mac80211.h	wifi: mac80211: support antenna control in injection	2023-09-25 09:12:34 +02:00
mac802154.h	mac802154: Drop IEEE802154_HW_RX_DROP_BAD_CKSUM	2022-10-12 12:57:19 +02:00
macsec.h	net: macsec: indicate next pn update when offloading	2023-10-10 10:30:30 +02:00
mctp.h	mctp: Reorder fields in 'struct mctp_route'	2023-06-20 20:06:16 -07:00
mctpdevice.h	…
mip6.h	…
mld.h	…
mpls.h	…
mpls_iptunnel.h	…
mptcp.h	mptcp: add struct mptcp_sched_ops	2023-08-22 17:31:18 -07:00
mrp.h	mrp: introduce active flags to prevent UAF when applicant uninit	2022-11-18 12:14:55 +00:00
ncsi.h	…
ndisc.h	ndisc: Remove unused ndisc_ifinfo_sysctl_strategy() declaration	2023-08-07 08:53:55 +01:00
neighbour.h	neighbour: fix data-races around n->output	2023-10-01 17:14:37 +01:00
net_debug.h	…
net_failover.h	…
net_namespace.h	net: treat possible_net_t net pointer as an RCU one and add read_pnet_rcu()	2023-10-18 09:23:01 +01:00
net_ratelimit.h	…
net_trackers.h	…
netdev_queues.h	net: add macro netif_subqueue_completed_wake	2023-04-18 12:59:01 +02:00
netdev_rx_queue.h	net: move struct netdev_rx_queue out of netdevice.h	2023-08-03 08:38:07 -07:00
netevent.h	…
netlabel.h	…
netlink.h	netlink: add variable-length / auto integers	2023-10-20 11:43:35 +01:00
netprio_cgroup.h	…
netrom.h	…
nexthop.h	nexthop: Annotate struct nh_group with __counted_by	2023-10-06 10:50:34 +01:00
nl802154.h	ieee802154: Add support for user beaconing requests	2023-01-28 13:51:22 +01:00
nsh.h	net: NSH: fix kernel-doc notation warning	2023-07-14 20:39:29 -07:00
p8022.h	net: 802: Remove unused function declarations	2023-08-04 15:33:50 -07:00
pie.h	pie: fix kernel-doc notation warning	2023-07-14 20:39:30 -07:00
ping.h	net/ipv4: ping_group_range: allow GID from 2147483648 to 4294967294	2023-06-02 09:55:22 +01:00
pkt_cls.h	net, sched: Make tc-related drop reason more flexible	2023-10-16 10:07:36 -07:00
pkt_sched.h	net_sched: constify qdisc_priv()	2023-10-01 13:20:36 +01:00
pptp.h	…
protocol.h	…
psample.h	…
psnap.h	…
raw.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-04-06 12:01:20 -07:00
rawv6.h	ipv6: raw: constify raw_v6_match() socket argument	2023-03-17 08:56:37 +00:00
red.h	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
regulatory.h	wifi: cfg80211: save power spectral density(psd) of regulatory rule	2023-09-18 09:44:05 +02:00
request_sock.h	…
rose.h	…
route.h	ipv4: rename and move ip_route_output_tunnel()	2023-10-16 09:57:52 +01:00
rpl.h	ipv6: rpl: Remove pskb(_may)?_pull() in ipv6_rpl_srh_rcv().	2023-06-19 11:32:58 -07:00
rsi_91x.h	rsi: remove kernel-doc comment marker	2023-07-14 20:39:30 -07:00
rtnetlink.h	net: validate veth and vxcan peer ifindexes	2023-08-20 11:40:03 +01:00
rtnh.h	…
sch_generic.h	net, sched: Make tc-related drop reason more flexible	2023-10-16 10:07:36 -07:00
scm.h	af_unix: Fix msg_controllen test in scm_pidfd_recv() for MSG_CMSG_COMPAT.	2023-09-04 11:00:17 +01:00
secure_seq.h	…
seg6.h	…
seg6_hmac.h	…
seg6_local.h	…
selftests.h	…
slhc_vj.h	…
smc.h	net/smc: Introduce explicit check for v2 support	2023-03-15 08:18:35 +00:00
snmp.h	…
sock.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-10-19 13:29:01 -07:00
sock_reuseport.h	soreuseport: Fix socket selection for SO_INCOMING_CPU.	2022-10-25 11:35:16 +02:00
stp.h	…
strparser.h	…
switchdev.h	net: switchdev: Remove unused declaration switchdev_port_fwd_mark_set()	2023-08-09 13:12:15 -07:00
tc_wrapper.h	net/sched: Retire rsvp classifier	2023-02-16 09:27:07 +01:00
tcp.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-10-19 13:29:01 -07:00
tcp_states.h	…
tcx.h	bpf: Add fd-based tcx multi-prog infra with link support	2023-07-19 10:07:27 -07:00
timewait_sock.h	…
tipc.h	…
tls.h	tls: use fixed size for tls_offload_context_{tx,rx}.driver_state	2023-10-13 11:26:10 +01:00
tls_prot.h	net/tls: Add TLS Alert definitions	2023-07-28 14:07:59 -07:00
tls_toe.h	…
transp_v6.h	inet6: Remove unused function declaration udpv6_connect()	2023-08-01 15:06:27 -07:00
tso.h	net: tso: inline tso_count_descs()	2022-12-12 15:04:39 -08:00
tun_proto.h	…
udp.h	udp/udplite: Remove unused function declarations udp{,lite}_get_port()	2023-08-07 08:53:55 +01:00
udp_tunnel.h	ipv4: add new arguments to udp_tunnel_dst_lookup()	2023-10-16 09:57:52 +01:00
udplite.h	udplite: fix various data-races	2023-09-14 16:16:36 +02:00
vsock_addr.h	…
vxlan.h	vxlan: Fix nexthop hash size	2023-08-02 10:58:26 +01:00
wext.h	…
x25.h	x25: preserve const qualifier in [a]x25_sk()	2023-03-18 12:23:34 +00:00
x25device.h	…
xdp.h	bpf: expose information about supported xdp metadata kfunc	2023-09-15 11:26:58 -07:00
xdp_priv.h	…
xdp_sock.h	xsk: add multi-buffer support for sockets sharing umem	2023-09-15 11:00:22 -07:00
xdp_sock_drv.h	xsk: support mbuf on ZC RX	2023-07-19 09:56:49 -07:00
xfrm.h	ipv6: lockless IPV6_DONTFRAG implementation	2023-09-15 10:33:47 +01:00
xsk_buff_pool.h	xsk: support mbuf on ZC RX	2023-07-19 09:56:49 -07:00