superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
mirror-linux/drivers/tty
History
Uwe Kleine-König bda3f46354 serial: stm32: Ignore return value of uart_remove_one_port() in .remove() 
[ Upstream commit 6bd6cd29c9 ]

Returning early from stm32_usart_serial_remove() results in a resource
leak as several cleanup functions are not called. The driver core ignores
the return value and there is no possibility to clean up later.

uart_remove_one_port() only returns non-zero if there is some
inconsistency (i.e. stm32_usart_driver.state[port->line].uart_port == NULL).
This should never happen, and even if it does it's a bad idea to exit
early in the remove callback without cleaning up.

This prepares changing the prototype of struct platform_driver::remove to
return void. See commit 5c5a7680e6 ("platform: Provide a remove callback
that returns no value") for further details about this quest.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230512173810.131447-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
 		2023-08-23 17:52:23 +02:00
..
hvc
…
ipwireless
…
serdev
…
serial serial: stm32: Ignore return value of uart_remove_one_port() in .remove() 2023-08-23 17:52:23 +02:00
vt vc_screen: reload load of struct vc_data pointer in vcs_write() to avoid UAF 2023-05-24 17:32:51 +01:00
Kconfig
…
Makefile
…
amiserial.c
…
ehv_bytechan.c
…
goldfish.c
…
mips_ejtag_fdc.c
…
moxa.c
…
mxser.c
…
n_gsm.c tty: n_gsm: fix UAF in gsm_cleanup_mux 2023-08-03 10:24:12 +02:00
n_hdlc.c
…
n_null.c
…
n_tty.c tty: fix hang on tty device with no_room set 2023-08-03 10:23:53 +02:00
nozomi.c
…
pty.c
…
rpmsg_tty.c
…
synclink_gt.c
…
sysrq.c
…
tty.h tty: Prevent writing chars during tcsetattr TCSADRAIN/FLUSH 2023-05-11 23:03:01 +09:00
tty_audit.c
…
tty_baudrate.c
…
tty_buffer.c
…
tty_io.c tty: Prevent writing chars during tcsetattr TCSADRAIN/FLUSH 2023-05-11 23:03:01 +09:00
tty_ioctl.c tty: Prevent writing chars during tcsetattr TCSADRAIN/FLUSH 2023-05-11 23:03:01 +09:00
tty_jobctrl.c
…
tty_ldisc.c
…
tty_ldsem.c
…
tty_mutex.c
…
tty_port.c
…
ttynull.c
…
vcc.c
…