Qu Huang 5104fdf50d drm/amdgpu: Fix a null pointer access when the smc_rreg pointer is NULL ... In certain types of chips, such as VEGA20, reading the amdgpu_regs_smc file could result in an abnormal null pointer access when the smc_rreg pointer is NULL. Below are the steps to reproduce this issue and the corresponding exception log: 1. Navigate to the directory: /sys/kernel/debug/dri/0 2. Execute command: cat amdgpu_regs_smc 3. Exception Log:: [4005007.702554] BUG: kernel NULL pointer dereference, address: 0000000000000000 [4005007.702562] #PF: supervisor instruction fetch in kernel mode [4005007.702567] #PF: error_code(0x0010) - not-present page [4005007.702570] PGD 0 P4D 0 [4005007.702576] Oops: 0010 [#1] SMP NOPTI [4005007.702581] CPU: 4 PID: 62563 Comm: cat Tainted: G OE 5.15.0-43-generic #46-Ubunt u [4005007.702590] RIP: 0010:0x0 [4005007.702598] Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6. [4005007.702600] RSP: 0018:ffffa82b46d27da0 EFLAGS: 00010206 [4005007.702605] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffa82b46d27e68 [4005007.702609] RDX: 0000000000000001 RSI: 0000000000000000 RDI: ffff9940656e0000 [4005007.702612] RBP: ffffa82b46d27dd8 R08: 0000000000000000 R09: ffff994060c07980 [4005007.702615] R10: 0000000000020000 R11: 0000000000000000 R12: 00007f5e06753000 [4005007.702618] R13: ffff9940656e0000 R14: ffffa82b46d27e68 R15: 00007f5e06753000 [4005007.702622] FS: 00007f5e0755b740(0000) GS:ffff99479d300000(0000) knlGS:0000000000000000 [4005007.702626] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [4005007.702629] CR2: ffffffffffffffd6 CR3: 00000003253fc000 CR4: 00000000003506e0 [4005007.702633] Call Trace: [4005007.702636] <TASK> [4005007.702640] amdgpu_debugfs_regs_smc_read+0xb0/0x120 [amdgpu] [4005007.703002] full_proxy_read+0x5c/0x80 [4005007.703011] vfs_read+0x9f/0x1a0 [4005007.703019] ksys_read+0x67/0xe0 [4005007.703023] __x64_sys_read+0x19/0x20 [4005007.703028] do_syscall_64+0x5c/0xc0 [4005007.703034] ? do_user_addr_fault+0x1e3/0x670 [4005007.703040] ? exit_to_user_mode_prepare+0x37/0xb0 [4005007.703047] ? irqentry_exit_to_user_mode+0x9/0x20 [4005007.703052] ? irqentry_exit+0x19/0x30 [4005007.703057] ? exc_page_fault+0x89/0x160 [4005007.703062] ? asm_exc_page_fault+0x8/0x30 [4005007.703068] entry_SYSCALL_64_after_hwframe+0x44/0xae [4005007.703075] RIP: 0033:0x7f5e07672992 [4005007.703079] Code: c0 e9 b2 fe ff ff 50 48 8d 3d fa b2 0c 00 e8 c5 1d 02 00 0f 1f 44 00 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 0f 05 <48> 3d 00 f0 ff ff 77 56 c3 0f 1f 44 00 00 48 83 e c 28 48 89 54 24 [4005007.703083] RSP: 002b:00007ffe03097898 EFLAGS: 00000246 ORIG_RAX: 0000000000000000 [4005007.703088] RAX: ffffffffffffffda RBX: 0000000000020000 RCX: 00007f5e07672992 [4005007.703091] RDX: 0000000000020000 RSI: 00007f5e06753000 RDI: 0000000000000003 [4005007.703094] RBP: 00007f5e06753000 R08: 00007f5e06752010 R09: 00007f5e06752010 [4005007.703096] R10: 0000000000000022 R11: 0000000000000246 R12: 0000000000022000 [4005007.703099] R13: 0000000000000003 R14: 0000000000020000 R15: 0000000000020000 [4005007.703105] </TASK> [4005007.703107] Modules linked in: nf_tables libcrc32c nfnetlink algif_hash af_alg binfmt_misc nls_ iso8859_1 ipmi_ssif ast intel_rapl_msr intel_rapl_common drm_vram_helper drm_ttm_helper amd64_edac t tm edac_mce_amd kvm_amd ccp mac_hid k10temp kvm acpi_ipmi ipmi_si rapl sch_fq_codel ipmi_devintf ipm i_msghandler msr parport_pc ppdev lp parport mtd pstore_blk efi_pstore ramoops pstore_zone reed_solo mon ip_tables x_tables autofs4 ib_uverbs ib_core amdgpu(OE) amddrm_ttm_helper(OE) amdttm(OE) iommu_v 2 amd_sched(OE) amdkcl(OE) drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec rc_core drm igb ahci xhci_pci libahci i2c_piix4 i2c_algo_bit xhci_pci_renesas dca [4005007.703184] CR2: 0000000000000000 [4005007.703188] ---[ end trace ac65a538d240da39 ]--- [4005007.800865] RIP: 0010:0x0 [4005007.800871] Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6. [4005007.800874] RSP: 0018:ffffa82b46d27da0 EFLAGS: 00010206 [4005007.800878] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffa82b46d27e68 [4005007.800881] RDX: 0000000000000001 RSI: 0000000000000000 RDI: ffff9940656e0000 [4005007.800883] RBP: ffffa82b46d27dd8 R08: 0000000000000000 R09: ffff994060c07980 [4005007.800886] R10: 0000000000020000 R11: 0000000000000000 R12: 00007f5e06753000 [4005007.800888] R13: ffff9940656e0000 R14: ffffa82b46d27e68 R15: 00007f5e06753000 [4005007.800891] FS: 00007f5e0755b740(0000) GS:ffff99479d300000(0000) knlGS:0000000000000000 [4005007.800895] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [4005007.800898] CR2: ffffffffffffffd6 CR3: 00000003253fc000 CR4: 00000000003506e0 Signed-off-by: Qu Huang <qu.huang@linux.dev> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>		2023-10-26 18:41:22 -04:00
..
accel	Linux 6.6-rc7	2023-10-23 18:20:06 +10:00
accessibility	…
acpi	Merge branch 'acpi-irq'	2023-10-20 17:31:15 +02:00
amba	…
android	binder: fix memory leaks of spam and pending work	2023-10-05 12:48:08 +02:00
ata	ata: pata_parport: fit3: implement IDE command set registers	2023-10-10 14:42:22 +09:00
atm	…
auxdisplay	…
base	regmap: Fix for v6.6	2023-10-18 09:30:03 -07:00
bcma	…
block	block-6.6-2023-10-06	2023-10-06 15:43:19 -07:00
bluetooth	Bluetooth: btrtl: Ignore error return for hci_devcd_register()	2023-10-13 20:03:04 -07:00
bus	bus: ti-sysc: Fix SYSC_QUIRK_SWSUP_SIDLE_ACT handling for uart wake-up	2023-09-13 10:24:53 +03:00
cache	cache: Add L2 cache management for Andes AX45MP RISC-V core	2023-09-01 09:08:59 -07:00
cdrom	…
cdx	…
char	Hi,	2023-09-13 11:44:20 -07:00
clk	clk: tegra: fix error return case for recalc_rate	2023-09-12 10:56:05 -07:00
clocksource	Updates for clocksource/clockevent drivers:	2023-09-04 13:15:57 -07:00
comedi	Revert "comedi: add HAS_IOPORT dependencies"	2023-09-12 15:49:20 +02:00
connector	…
counter	First set of Counter fixes for 6.6	2023-10-02 13:13:15 +02:00
cpufreq	…
cpuidle	…
crypto	…
cxl	cxl/acpi: Annotate struct cxl_cxims_data with __counted_by	2023-09-22 14:31:04 -07:00
dax	…
dca	…
devfreq	…
dio	…
dma	dmaengine fixes for v6.6	2023-10-13 08:52:57 -07:00
dma-buf	dma-buf: add dma_fence_timestamp helper	2023-10-05 11:05:58 +02:00
edac	…
eisa	…
extcon	…
firewire	scsi: sd: Differentiate system and runtime start/stop management	2023-09-28 21:23:00 +09:00
firmware	Final set of EFI tweaks for v6.6:	2023-10-22 07:05:28 -10:00
fpga	…
fsi	…
gnss	…
gpio	gpiolib: acpi: Add missing memset(0) to acpi_get_gpiod_from_data()	2023-10-20 11:24:16 +02:00
gpu	drm/amdgpu: Fix a null pointer access when the smc_rreg pointer is NULL	2023-10-26 18:41:22 -04:00
greybus	…
hid	Linux 6.6-rc7	2023-10-23 18:20:06 +10:00
hsi	…
hte	…
hv	hyperv-next for v6.6	2023-09-04 11:26:29 -07:00
hwmon	hwmon: (nct6775) Fix non-existent ALARM warning	2023-09-18 11:52:18 -07:00
hwspinlock	…
hwtracing	coresight: tmc-etr: Disable warnings for allocation failures	2023-09-20 10:46:30 +01:00
i2c	i2c: npcm7xx: Fix callback completion ordering	2023-09-27 21:32:06 +02:00
i3c	i3c: master: svc: fix probe failure when no i3c device exist	2023-09-06 01:21:47 +02:00
idle	…
iio	iio: pressure: ms5611: ms5611_prom_is_valid false negative bug	2023-10-05 18:06:46 +01:00
infiniband	RDMA/core: Require admin capabilities to set system parameters	2023-10-05 20:01:47 +03:00
input	Input updates for v6.6-rc5	2023-10-13 23:19:16 -07:00
interconnect	…
iommu	iommu/vt-d: Avoid memory allocation in iommu_suspend()	2023-09-25 16:10:36 +02:00
ipack	…
irqchip	A set of updates for interrupt chip drivers:	2023-10-10 11:14:07 -07:00
isdn	…
leds	leds: Drop BUG_ON check for LED_COLOR_ID_MULTI	2023-09-19 15:16:23 +01:00
macintosh	…
mailbox	mailbox: qcom-ipcc: fix incorrect num_chans counting	2023-09-05 10:11:01 -05:00
mcb	mcb: remove is_added flag from mcb_device struct	2023-10-05 09:50:14 +02:00
md	This push fixes a 6.5 regression in dm-crypt.	2023-10-10 10:47:35 -07:00
media	Linux 6.6-rc7	2023-10-23 18:20:06 +10:00
memory	…
memstick	…
message	…
mfd	Couple of small fixes, including:	2023-10-05 11:03:20 -07:00
misc	misc: rtsx: Fix some platforms can not boot and move the l1ss judgment to probe	2023-09-25 10:48:19 +02:00
mmc	mmc: core: Capture correct oemid-bits for eMMC cards	2023-09-27 12:17:04 +02:00
most	…
mtd	In the raw NAND subsystem, the major fix prevents using cached reads	2023-10-20 13:12:34 -07:00
mux	…
net	Including fixes from bluetooth, netfilter, WiFi.	2023-10-19 12:08:18 -07:00
nfc	…
ntb	…
nubus	…
nvdimm	…
nvme	nvme-pci: add BOGUS_NID for Intel 0a54 device	2023-10-18 14:08:39 -07:00
nvmem	…
of	of: overlay: Reorder struct fragment fields kerneldoc	2023-10-02 11:34:23 -05:00
opp	…
parisc	…
parport	TTY/Serial driver changes for 6.6-rc1	2023-09-01 09:38:00 -07:00
pci	pci-v6.6-fixes-2	2023-10-06 09:11:13 -07:00
pcmcia	…
peci	…
perf	RISC-V Fixes for 6.6-rc6	2023-10-13 09:17:48 -07:00
phy	phy fixes for 6.6	2023-10-22 07:11:10 -10:00
pinctrl	Revert "pinctrl: avoid unsafe code pattern in find_pinctrl()"	2023-10-19 10:12:48 +02:00
platform	platform/mellanox: mlxbf-tmfifo: Fix a warning message	2023-10-18 15:38:09 +02:00
pmdomain	pmdomain: imx: scu-pd: correct DMA2 channel	2023-10-05 00:28:52 +02:00
pnp	…
power	power: supply: qcom_battmgr: fix enable request endianness	2023-09-30 21:00:20 +02:00
powercap	powercap: intel_rapl: Fix invalid setting of Power Limit 4	2023-09-06 22:21:22 +02:00
pps	…
ps3	…
ptp	ptp: ocp: Fix error handling in ptp_ocp_device_init	2023-10-02 07:19:22 +01:00
pwm	pwm: Changes for v6.6-rc1	2023-09-07 18:05:58 -07:00
rapidio	…
ras	…
regulator	regulator/core: Revert "fix kobject release warning and memory leak in regulator_register()"	2023-09-26 17:26:08 +02:00
remoteproc	remoteproc updates for v6.6	2023-09-04 15:12:26 -07:00
reset	…
rpmsg	rpmsg updates for v6.6	2023-09-04 15:08:52 -07:00
rtc	RTC for 6.6	2023-09-07 16:07:35 -07:00
s390	s390 updates for 6.6-rc7	2023-10-21 10:11:11 -07:00
sbus	…
scsi	SCSI fixes on 20231020	2023-10-20 13:24:50 -07:00
sh	…
siox	…
slimbus	…
soc	ARM: SoC fixes for 6.6, part 2	2023-10-12 11:52:23 -07:00
soundwire	soundwire: bus: Make IRQ handling conditionally built	2023-09-21 11:31:33 +02:00
spi	spi: npcm-fiu: Fix UMA reads when dummy.nbytes == 0	2023-10-02 15:03:19 +01:00
spmi	…
ssb	…
staging	Linux 6.6-rc7	2023-10-23 18:20:06 +10:00
target	scsi: target: core: Fix deadlock due to recursive locking	2023-09-27 10:55:29 -04:00
tc	…
tee	ARM: SoC fixes for 6.6, part 2	2023-10-12 11:52:23 -07:00
thermal	thermal: sysfs: Fix trip_point_hyst_store()	2023-09-18 13:13:05 +02:00
thunderbolt	thunderbolt: Fix for v6.6-rc7	2023-10-17 19:25:42 +02:00
tty	serial: core: Fix checks for tx runtime PM state	2023-10-07 11:23:47 +02:00
ufs	scsi: ufs: core: Correct clear TM error log	2023-10-09 21:33:30 -04:00
uio	…
usb	usb: typec: altmodes/displayport: fixup drm internal api change vs new user.	2023-10-27 07:55:41 +10:00
vdpa	virtio: features	2023-09-04 10:43:44 -07:00
vfio	vfio/mdev: Fix a null-ptr-deref bug for mdev_unregister_parent()	2023-09-22 12:48:04 -06:00
vhost	vringh: don't use vringh_kiov_advance() in vringh_iov_xfer()	2023-10-04 08:26:48 +01:00
video	Linux 6.6-rc7	2023-10-23 18:20:06 +10:00
virt	…
virtio	virtio_ring: fix avail_wrap_counter in virtqueue_add_packed	2023-09-03 18:10:24 -04:00
vlynq	…
w1	w1: ds2482: Switch back to use struct i2c_driver's .probe()	2023-09-13 10:48:42 +02:00
watchdog	linux-watchdog 6.6-rc1 tag	2023-09-06 09:19:12 -07:00
xen	xen/events: replace evtchn_rwlock with RCU	2023-10-09 09:21:16 +02:00
zorro	…
Kconfig	Merge patch series "Add non-coherent DMA support for AX45MP"	2023-09-08 11:24:34 -07:00
Makefile	pmdomain: Rename the genpd subsystem to pmdomain	2023-09-13 11:09:21 +02:00