f85981327a
The loop in bench_sockmap_prog_destroy() has two issues: 1. Using 'sizeof(ctx.fds)' as the loop bound results in the number of bytes, not the number of file descriptors, causing the loop to iterate far more times than intended. 2. The condition 'ctx.fds[0] > 0' incorrectly checks only the first fd for all iterations, potentially leaving file descriptors unclosed. Change it to 'ctx.fds[i] > 0' to check each fd properly. These fixes ensure correct cleanup of all file descriptors when the benchmark exits. Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Link: https://lore.kernel.org/bpf/20250909124721.191555-1-jiayuan.chen@linux.dev Closes: https://lore.kernel.org/bpf/aLqfWuRR9R_KTe5e@stanley.mountain/ |
||
|---|---|---|
| .. | ||
| bench_bloom_filter_map.c | ||
| bench_bpf_crypto.c | ||
| bench_bpf_hashmap_full_update.c | ||
| bench_bpf_hashmap_lookup.c | ||
| bench_bpf_loop.c | ||
| bench_count.c | ||
| bench_htab_mem.c | ||
| bench_local_storage.c | ||
| bench_local_storage_create.c | ||
| bench_local_storage_rcu_tasks_trace.c | ||
| bench_lpm_trie_map.c | ||
| bench_rename.c | ||
| bench_ringbufs.c | ||
| bench_sockmap.c | ||
| bench_strncmp.c | ||
| bench_trigger.c | ||
| run_bench_bloom_filter_map.sh | ||
| run_bench_bpf_hashmap_full_update.sh | ||
| run_bench_bpf_loop.sh | ||
| run_bench_htab_mem.sh | ||
| run_bench_local_storage.sh | ||
| run_bench_local_storage_rcu_tasks_trace.sh | ||
| run_bench_rename.sh | ||
| run_bench_ringbufs.sh | ||
| run_bench_strncmp.sh | ||
| run_bench_trigger.sh | ||
| run_bench_uprobes.sh | ||
| run_common.sh | ||