Eric Dumazet 55caf900e1 net: add vlan_get_protocol_and_depth() helper ... [ Upstream commit 4063384ef7 ] Before blamed commit, pskb_may_pull() was used instead of skb_header_pointer() in __vlan_get_protocol() and friends. Few callers depended on skb->head being populated with MAC header, syzbot caught one of them (skb_mac_gso_segment()) Add vlan_get_protocol_and_depth() to make the intent clearer and use it where sensible. This is a more generic fix than commit e9d3f80935 ("net/af_packet: make sure to pull mac header") which was dealing with a similar issue. kernel BUG at include/linux/skbuff.h:2655 ! invalid opcode: 0000 [#1] SMP KASAN CPU: 0 PID: 1441 Comm: syz-executor199 Not tainted 6.1.24-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/14/2023 RIP: 0010:__skb_pull include/linux/skbuff.h:2655 [inline] RIP: 0010:skb_mac_gso_segment+0x68f/0x6a0 net/core/gro.c:136 Code: fd 48 8b 5c 24 10 44 89 6b 70 48 c7 c7 c0 ae 0d 86 44 89 e6 e8 a1 91 d0 00 48 c7 c7 00 af 0d 86 48 89 de 31 d2 e8 d1 4a e9 ff <0f> 0b 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 55 48 89 e5 41 RSP: 0018:ffffc90001bd7520 EFLAGS: 00010286 RAX: ffffffff8469736a RBX: ffff88810f31dac0 RCX: ffff888115a18b00 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 RBP: ffffc90001bd75e8 R08: ffffffff84697183 R09: fffff5200037adf9 R10: 0000000000000000 R11: dffffc0000000001 R12: 0000000000000012 R13: 000000000000fee5 R14: 0000000000005865 R15: 000000000000fed7 FS: 000055555633f300(0000) GS:ffff8881f6a00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000020000000 CR3: 0000000116fea000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> [<ffffffff847018dd>] __skb_gso_segment+0x32d/0x4c0 net/core/dev.c:3419 [<ffffffff8470398a>] skb_gso_segment include/linux/netdevice.h:4819 [inline] [<ffffffff8470398a>] validate_xmit_skb+0x3aa/0xee0 net/core/dev.c:3725 [<ffffffff84707042>] __dev_queue_xmit+0x1332/0x3300 net/core/dev.c:4313 [<ffffffff851a9ec7>] dev_queue_xmit+0x17/0x20 include/linux/netdevice.h:3029 [<ffffffff851b4a82>] packet_snd net/packet/af_packet.c:3111 [inline] [<ffffffff851b4a82>] packet_sendmsg+0x49d2/0x6470 net/packet/af_packet.c:3142 [<ffffffff84669a12>] sock_sendmsg_nosec net/socket.c:716 [inline] [<ffffffff84669a12>] sock_sendmsg net/socket.c:736 [inline] [<ffffffff84669a12>] __sys_sendto+0x472/0x5f0 net/socket.c:2139 [<ffffffff84669c75>] __do_sys_sendto net/socket.c:2151 [inline] [<ffffffff84669c75>] __se_sys_sendto net/socket.c:2147 [inline] [<ffffffff84669c75>] __x64_sys_sendto+0xe5/0x100 net/socket.c:2147 [<ffffffff8551d40f>] do_syscall_x64 arch/x86/entry/common.c:50 [inline] [<ffffffff8551d40f>] do_syscall_64+0x2f/0x50 arch/x86/entry/common.c:80 [<ffffffff85600087>] entry_SYSCALL_64_after_hwframe+0x63/0xcd Fixes: 469aceddfa ("vlan: consolidate VLAN parsing code and limit max parsing depth") Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Toke Høiland-Jørgensen <toke@redhat.com> Cc: Willem de Bruijn <willemb@google.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-05-24 17:32:32 +01:00
..
accessibility	…
acpi	ACPI: PM: Do not turn of unused power resources on the Toshiba Click Mini	2023-05-11 23:03:38 +09:00
amba	…
android	…
ata	…
atm	atm: idt77252: fix kmemleak when rmmod idt77252	2023-03-30 12:49:09 +02:00
auxdisplay	auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()	2023-03-11 13:55:16 +01:00
base	cacheinfo: Check sib_leaf in cache_leaves_are_shared()	2023-05-11 23:03:29 +09:00
bcma	…
block	drbd: correctly submit flush bio on barrier	2023-05-11 23:03:39 +09:00
bluetooth	Revert "Bluetooth: btsdio: fix use after free bug in btsdio_remove due to unfinished work"	2023-05-11 23:03:26 +09:00
bus	bus: mhi: host: Range check CHDBOFF and ERDBOFF	2023-05-11 23:03:05 +09:00
cdrom	…
char	ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it	2023-05-11 23:03:26 +09:00
clk	clk: rockchip: rk3399: allow clk_cifout to force clk_cifout_src to reparent	2023-05-11 23:03:40 +09:00
clocksource	clocksource/drivers/davinci: Fix memory leak in davinci_timer_register when init fails	2023-05-11 23:03:35 +09:00
comedi	…
connector	…
counter	counter: 104-quad-8: Fix Synapse action reported for Index signals	2023-04-13 16:55:31 +02:00
cpufreq	cpufreq: use correct unit when verify cur freq	2023-05-11 23:03:16 +09:00
cpuidle	RISC-V: Align SBI probe implementation with spec	2023-05-11 23:03:04 +09:00
crypto	crypto: sun8i-ss - Fix a test in sun8i_ss_setup_ivs()	2023-05-17 11:53:40 +02:00
cxl	cxl/hdm: Fail upon detecting 0-sized decoders	2023-05-11 23:03:05 +09:00
dax	dax/kmem: Fix leak of memory-hotplug resources	2023-03-10 09:34:25 +01:00
dca	…
devfreq	…
dio	…
dma	dmaengine: at_xdmac: do not enable all cyclic channels	2023-05-11 23:03:37 +09:00
dma-buf	…
edac	qcom: llcc/edac: Support polling mode for ECC handling	2023-05-17 11:53:28 +02:00
eisa	…
extcon	…
firewire	…
firmware	firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in probe	2023-05-11 23:03:30 +09:00
fpga	fpga: bridge: fix kernel-doc parameter description	2023-05-11 23:03:27 +09:00
fsi	…
gnss	…
gpio	gpiolib: acpi: Add a ignore wakeup quirk for Clevo NL5xNU	2023-05-01 08:26:27 +09:00
gpu	drm/mipi-dsi: Set the fwnode for mipi_dsi_device	2023-05-24 17:32:31 +01:00
greybus	…
hid	HID: wacom: insert timestamp to packed Bluetooth (BT) events	2023-05-17 11:53:51 +02:00
hsi	…
hte	hte: tegra-194: Fix off by one in tegra_hte_map_to_line_id()	2023-05-11 23:03:38 +09:00
hv	Drivers: vmbus: Check for channel allocation before looking up relids	2023-04-13 16:55:18 +02:00
hwmon	hwmon: (pmbus/fsp-3y) Fix functionality bitmask in FSP-3Y YM-2151E	2023-05-11 23:03:16 +09:00
hwspinlock	…
hwtracing	coresight: etm_pmu: Set the module field	2023-05-11 23:03:29 +09:00
i2c	i2c: tegra: Fix PEC support for SMBUS block read	2023-05-17 11:53:34 +02:00
i3c	…
idle	Revert "cpuidle, intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE *again*"	2023-04-06 12:10:58 +02:00
iio	iio: light: max44009: add missing OF device matching	2023-05-11 23:03:27 +09:00
infiniband	RDMA/mlx5: Use correct device num_ports when modify DC	2023-05-11 23:03:35 +09:00
input	Input: raspberrypi-ts - fix refcount leak in rpi_ts_probe	2023-05-11 23:03:35 +09:00
interconnect	interconnect: qcom: rpm: drop bogus pm domain attach	2023-05-11 23:03:28 +09:00
iommu	iommu/amd: Set page size bitmap during V2 domain allocation	2023-05-11 23:03:34 +09:00
ipack	…
irqchip	irqchip/loongson-eiointc: Fix registration of syscore_ops	2023-05-17 11:53:53 +02:00
isdn	…
leds	leds: tca6507: Fix error handling of using fwnode_property_read_string	2023-05-11 23:03:36 +09:00
macintosh	macintosh: via-pmu-led: requires ATA to be set	2023-05-11 23:03:31 +09:00
mailbox	mailbox: zynqmp: Fix counts of child nodes	2023-05-17 11:53:28 +02:00
mcb	…
md	dm: don't lock fs when the map is NULL in process of resume	2023-05-11 23:03:41 +09:00
media	media: mediatek: vcodec: add remove function for decoder platform driver	2023-05-11 23:03:16 +09:00
memory	memory: tegra30-emc: fix interconnect registration race	2023-03-22 13:33:56 +01:00
memstick	memstick: fix memory leak if card device is never registered	2023-04-26 14:28:39 +02:00
message	…
mfd	mfd: arizona-spi: Add missing MODULE_DEVICE_TABLE	2023-05-11 23:03:38 +09:00
misc	vmci_host: fix a race condition in vmci_host_poll() causing GPF	2023-05-11 23:03:28 +09:00
mmc	mmc: sdhci-of-esdhc: fix quirk to ignore command inhibit for data	2023-05-11 23:03:11 +09:00
most	…
mtd	mtd: spi-nor: spansion: Enable JFFS2 write buffer for Infineon s25hx SEMPER flash	2023-05-17 11:53:29 +02:00
mux	…
net	net: add vlan_get_protocol_and_depth() helper	2023-05-24 17:32:32 +01:00
nfc	nfc: st-nci: Fix use after free bug in ndlc_remove due to race condition	2023-03-22 13:33:46 +01:00
ntb	…
nubus	…
nvdimm	cxl/pmem: Fix nvdimm registration races	2023-03-10 09:34:20 +01:00
nvme	nvme-fcloop: fix "inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage"	2023-05-11 23:03:22 +09:00
nvmem	…
of	of: Fix modalias string generation	2023-05-11 23:03:28 +09:00
opp	…
parisc	…
parport	…
pci	PCI/PM: Extend D3hot delay for NVIDIA HDA controllers	2023-05-11 23:03:29 +09:00
pcmcia	…
peci	…
perf	perf/arm-cmn: Fix port detection for CMN-700	2023-05-11 23:03:16 +09:00
phy	phy: ti: j721e-wiz: Fix unreachable code in wiz_mode_select()	2023-05-11 23:03:37 +09:00
pinctrl	pinctrl-bcm2835.c: fix race condition when setting gpio dir	2023-05-11 23:03:37 +09:00
platform	platform/x86: thinkpad_acpi: Add profile force ability	2023-05-17 11:53:44 +02:00
pnp	…
power	power: supply: rk817: Fix low SOC bugs	2023-05-11 23:03:34 +09:00
powercap	…
pps	…
ps3	…
ptp	ptp_qoriq: fix memory leak in probe()	2023-04-06 12:10:44 +02:00
pwm	pwm: mtk-disp: Configure double buffering before reading in .get_state()	2023-05-11 23:03:37 +09:00
rapidio	…
ras	…
regulator	regulator: stm32-pwr: fix of_iomap leak	2023-05-11 23:03:16 +09:00
remoteproc	remoteproc: rcar_rproc: Call of_node_put() on iteration error	2023-05-17 11:53:46 +02:00
reset	…
rpmsg	rpmsg: glink: Propagate TX failures in intentless mode as well	2023-05-11 23:03:16 +09:00
rtc	rtc: k3: handle errors while enabling wake irq	2023-05-11 23:03:33 +09:00
s390	s390/dasd: fix hanging blockdevice after request requeue	2023-05-11 23:03:40 +09:00
sbus	…
scsi	scsi: qedi: Fix use after free bug in qedi_remove()	2023-05-17 11:53:30 +02:00
sh	…
siox	…
slimbus	…
soc	soc: qcom: llcc: Do not create EDAC platform device on SDM845	2023-05-17 11:53:28 +02:00
soundwire	soundwire: intel: don't save hw_params for use in prepare	2023-05-11 23:03:37 +09:00
spi	spi: fsl-cpm: Use 16 bit mode for large transfers with even size	2023-05-17 11:54:00 +02:00
spmi	spmi: Add a check for remove callback when removing a SPMI driver	2023-05-11 23:03:31 +09:00
ssb	…
staging	staging: rtl8192e: Fix W_DISABLE# does not work after stop/start	2023-05-11 23:03:30 +09:00
target	scsi: target: iscsit: Fix TAS handling during conn cleanup	2023-05-11 23:03:19 +09:00
tc	…
tee	tee: amdtee: fix race condition in amdtee_open_session	2023-03-30 12:49:29 +02:00
thermal	thermal/drivers/mediatek: Use devm_of_iomap to avoid resource leak in mtk_thermal_probe	2023-05-11 23:03:37 +09:00
thunderbolt	thunderbolt: Use correct type in tb_port_is_clx_enabled() prototype	2023-05-11 23:03:41 +09:00
tty	serial: 8250: Add missing wakeup event reporting	2023-05-11 23:03:30 +09:00
ufs	scsi: ufs: core: Fix I/O hang that occurs when BKOPS fails in W-LUN suspend	2023-05-24 17:32:31 +01:00
uio	…
usb	usb: dwc3: gadget: Execute gadget stop after halting the controller	2023-05-17 11:53:26 +02:00
vdpa	vp_vdpa: fix the crash in hot unplug with vp_vdpa	2023-03-22 13:34:03 +01:00
vfio	vfio/type1: restore locked_vm	2023-03-10 09:34:32 +01:00
vhost	vhost_vdpa: fix unmap process in no-batch mode	2023-05-11 23:03:41 +09:00
video	fbdev: mmp: Fix deferred clk handling in mmphw_probe()	2023-05-11 23:03:31 +09:00
virt	virt/coco/sev-guest: Double-buffer messages	2023-05-11 23:03:10 +09:00
virtio	virtio_ring: don't update event idx on get_buf	2023-05-11 23:03:31 +09:00
vlynq	…
w1	…
watchdog	watchdog: dw_wdt: Fix the error handling path of dw_wdt_drv_probe()	2023-05-17 11:53:34 +02:00
xen	ACPI: processor: Fix evaluating _PDC method when running as Xen dom0	2023-05-11 23:03:11 +09:00
zorro	…
Kconfig	…
Makefile	…