mirror-linux/drivers/platform
Armin Wolf 44a96796d2 platform/x86: wmi: Fix opening of char device
[ Upstream commit eba9ac7aba ]

Since commit fa1f68db6c ("drivers: misc: pass miscdevice pointer via
file private data"), the miscdevice stores a pointer to itself inside
filp->private_data, which means that private_data will not be NULL when
wmi_char_open() is called. This might cause memory corruption should
wmi_char_open() be unable to find its driver, something which can
happen when the associated WMI device is deleted in wmi_free_devices().

Fix the problem by using the miscdevice pointer to retrieve the WMI
device data associated with a char device using container_of(). This
also avoids wmi_char_open() picking a wrong WMI device bound to a
driver with the same name as the original driver.

Fixes: 44b6b76611 ("platform/x86: wmi: create userspace interface for drivers")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20231020211005.38216-5-W_Armin@gmx.de
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-11-20 11:51:57 +01:00
..
chrome platform/chrome: chromeos_acpi: print hex string for ACPI_TYPE_BUFFER 2023-09-13 09:43:03 +02:00
goldfish
loongarch
mellanox platform/mellanox: mlxbf-tmfifo: Fix a warning message 2023-11-08 14:11:01 +01:00
mips
olpc
surface platform/surface: platform_profile: Propagate error if profile registration fails 2023-10-25 12:03:15 +02:00
x86 platform/x86: wmi: Fix opening of char device 2023-11-20 11:51:57 +01:00
Kconfig
Makefile