API compliance scanning with coccinelle flagged: Converting milliseconds to jiffies by "val * HZ / 1000" is technically is not a clean solution as it does not handle all corner cases correctly. By changing the conversion to use msecs_to_jiffies(val) conversion is correct in all cases. in the current code: mod_timer(&self->rx_defer_timer, jiffies + (10 * HZ / 1000)); for HZ < 100 (e.g. CONFIG_HZ == 64|32 in alpha) this effectively results in no delay at all. Patch was compile tested for x86_64_defconfig (implies CONFIG_USB_IRDA=m) Patch is against 4.1-rc4 (localversion-next is -next-20150522) Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Signed-off-by: David S. Miller <davem@davemloft.net> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| act200l-sir.c | ||
| actisys-sir.c | ||
| ali-ircc.c | ||
| ali-ircc.h | ||
| au1k_ir.c | ||
| bfin_sir.c | ||
| bfin_sir.h | ||
| donauboe.c | ||
| donauboe.h | ||
| esi-sir.c | ||
| girbil-sir.c | ||
| irda-usb.c | ||
| irda-usb.h | ||
| irtty-sir.c | ||
| irtty-sir.h | ||
| kingsun-sir.c | ||
| ks959-sir.c | ||
| ksdazzle-sir.c | ||
| litelink-sir.c | ||
| ma600-sir.c | ||
| mcp2120-sir.c | ||
| mcs7780.c | ||
| mcs7780.h | ||
| nsc-ircc.c | ||
| nsc-ircc.h | ||
| old_belkin-sir.c | ||
| pxaficp_ir.c | ||
| sa1100_ir.c | ||
| sh_irda.c | ||
| sh_sir.c | ||
| sir-dev.h | ||
| sir_dev.c | ||
| sir_dongle.c | ||
| smsc-ircc2.c | ||
| smsc-ircc2.h | ||
| smsc-sio.h | ||
| stir4200.c | ||
| tekram-sir.c | ||
| toim3232-sir.c | ||
| via-ircc.c | ||
| via-ircc.h | ||
| vlsi_ir.c | ||
| vlsi_ir.h | ||
| w83977af.h | ||
| w83977af_ir.c | ||
| w83977af_ir.h | ||