Linux kernel source tree
 
 
 
 
 
 
Go to file
Andrzej Hajda 84a6e47545 drm/i915: do not clean GT table on error path
[ Upstream commit 0561794b6b ]

The only task of intel_gt_release_all is to zero gt table. Calling
it on error path prevents intel_gt_driver_late_release_all (called from
i915_driver_late_release) to cleanup GTs, causing leakage.
After i915_driver_late_release GT array is not used anymore so
it does not need cleaning at all.

Sample leak report:

BUG i915_request (...): Objects remaining in i915_request on __kmem_cache_shutdown()
...
Object 0xffff888113420040 @offset=64
Allocated in __i915_request_create+0x75/0x610 [i915] age=18339 cpu=1 pid=1454
 kmem_cache_alloc+0x25b/0x270
 __i915_request_create+0x75/0x610 [i915]
 i915_request_create+0x109/0x290 [i915]
 __engines_record_defaults+0xca/0x440 [i915]
 intel_gt_init+0x275/0x430 [i915]
 i915_gem_init+0x135/0x2c0 [i915]
 i915_driver_probe+0x8d1/0xdc0 [i915]

v2: removed whole intel_gt_release_all

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8489
Fixes: bec68cc9ea ("drm/i915: Prepare for multiple GTs")
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231115-dont_clean_gt_on_error_path-v2-1-54250125470a@intel.com
(cherry picked from commit e899505533)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-12-03 07:32:07 +01:00
Documentation smp,csd: Throw an error if a CSD lock is stuck for too long 2023-11-28 17:06:55 +00:00
LICENSES
arch RISC-V: drop error print from riscv_hartid_to_cpuid() 2023-11-28 17:07:23 +00:00
block blk-core: use pr_warn_ratelimited() in bio_check_ro() 2023-11-20 11:52:17 +01:00
certs
crypto crypto: pcrypt - Fix hungtask for PADATA_RESET 2023-11-28 17:06:58 +00:00
drivers drm/i915: do not clean GT table on error path 2023-12-03 07:32:07 +01:00
fs afs: Make error on cell lookup failure consistent with OpenAFS 2023-12-03 07:32:07 +01:00
include tracing: Have trace_event_file have ref counters 2023-11-28 17:07:23 +00:00
init proc: sysctl: prevent aliased sysctls from getting passed to init 2023-11-28 17:07:08 +00:00
io_uring io_uring/net: ensure socket is marked connected on connect retry 2023-11-20 11:52:18 +01:00
ipc
kernel tracing: Have trace_event_file have ref counters 2023-11-28 17:07:23 +00:00
lib lib/generic-radix-tree.c: Don't overflow in peek() 2023-11-28 17:06:54 +00:00
mm mm: kmem: drop __GFP_NOFAIL when allocating objcg vectors 2023-11-28 17:07:20 +00:00
net mptcp: fix setsockopt(IP_TOS) subflow locking 2023-11-28 17:07:20 +00:00
rust rust: allocator: Prevent mis-aligned allocation 2023-08-11 12:08:18 +02:00
samples fprobe: Pass entry_data to handlers 2023-10-25 12:03:12 +02:00
scripts randstruct: Fix gcc-plugin performance mode to stay in group 2023-11-28 17:07:07 +00:00
security ima: detect changes to the backing overlay file 2023-11-28 17:07:12 +00:00
sound ALSA: hda/realtek: Add quirks for HP Laptops 2023-11-28 17:07:16 +00:00
tools cxl/region: Fix x1 root-decoder granularity calculations 2023-11-28 17:07:18 +00:00
usr
virt kvm/vfio: ensure kvg instance stays around in kvm_vfio_group_add() 2023-09-13 09:42:46 +02:00
.clang-format
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore
.mailmap
.rustfmt.toml
COPYING
CREDITS
Kbuild
Kconfig
MAINTAINERS devlink: move code to a dedicated directory 2023-08-30 16:11:00 +02:00
Makefile Linux 6.1.64 2023-11-28 17:07:23 +00:00
README

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.