mirror-linux/drivers/net
Chenguang Zhao 0e2909c6be net/mlx5: Fix variable not being completed when function returns
When cmd_alloc_index(), fails cmd_work_handler() needs
to complete ent->slotted before returning early.
Otherwise the task which issued the command may hang:

   mlx5_core 0000:01:00.0: cmd_work_handler:877:(pid 3880418): failed to allocate command entry
   INFO: task kworker/13:2:4055883 blocked for more than 120 seconds.
         Not tainted 4.19.90-25.44.v2101.ky10.aarch64 #1
   "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
   kworker/13:2    D    0 4055883      2 0x00000228
   Workqueue: events mlx5e_tx_dim_work [mlx5_core]
   Call trace:
      __switch_to+0xe8/0x150
      __schedule+0x2a8/0x9b8
      schedule+0x2c/0x88
      schedule_timeout+0x204/0x478
      wait_for_common+0x154/0x250
      wait_for_completion+0x28/0x38
      cmd_exec+0x7a0/0xa00 [mlx5_core]
      mlx5_cmd_exec+0x54/0x80 [mlx5_core]
      mlx5_core_modify_cq+0x6c/0x80 [mlx5_core]
      mlx5_core_modify_cq_moderation+0xa0/0xb8 [mlx5_core]
      mlx5e_tx_dim_work+0x54/0x68 [mlx5_core]
      process_one_work+0x1b0/0x448
      worker_thread+0x54/0x468
      kthread+0x134/0x138
      ret_from_fork+0x10/0x18

Fixes: 485d65e135 ("net/mlx5: Add a timeout to acquire the command queue semaphore")
Signed-off-by: Chenguang Zhao <zhaochenguang@kylinos.cn>
Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
Acked-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20250108030009.68520-1-zhaochenguang@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2025-01-09 08:28:23 -08:00
..
arcnet
bonding bonding: Fix feature propagation of NETIF_F_GSO_ENCAP_ALL 2024-12-12 11:59:18 +01:00
caif
can can: m_can: fix missed interrupts with m_can_pci 2024-12-18 09:30:52 +01:00
dsa net: dsa: microchip: Fix LAN937X set_ageing_time function 2024-12-19 18:04:04 -08:00
ethernet net/mlx5: Fix variable not being completed when function returns 2025-01-09 08:28:23 -08:00
fddi
fjes
hamradio
hippi
hyperv
ieee802154 Merge tag 'ieee802154-for-net-2025-01-03' of git://git.kernel.org/pub/scm/linux/kernel/git/wpan/wpan 2025-01-04 17:00:44 -08:00
ipa
ipvlan
mctp mctp i3c: fix MCTP I3C driver multi-thread issue 2025-01-09 11:52:38 +01:00
mdio net: mdiobus: fix an OF node reference leak 2024-12-19 11:45:42 +01:00
netdevsim net: netdevsim: fix nsim_pp_hold_write() 2024-12-17 17:46:17 -08:00
pcs
phy net: phy: micrel: Dynamically control external clock of KSZ PHY 2024-12-19 17:29:20 -08:00
plip
ppp
pse-pd net: pse-pd: tps23881: Fix power on/off issue 2024-12-23 10:40:34 -08:00
slip
team team: Fix feature exposure when no ports are present 2024-12-16 18:23:12 -08:00
thunderbolt
usb net: usb: qmi_wwan: add Quectel RG255C 2024-12-18 17:24:03 -08:00
vmxnet3
vxlan ndo_fdb_del: Add a parameter to report whether notification was sent 2024-11-15 16:39:18 -08:00
wan
wireguard wireguard: device: support big tcp GSO 2024-11-18 19:32:27 -08:00
wireless wifi: cw1200: Fix potential NULL dereference 2024-12-18 19:58:27 +02:00
wwan net: wwan: iosm: Properly check for valid exec stage in ipc_mmio_init() 2025-01-02 18:37:50 -08:00
xen-netback
Kconfig
LICENSE.SRC
Makefile
Space.c
amt.c
bareudp.c
dummy.c
eql.c
geneve.c geneve: do not assume mac header is set in geneve_xmit_skb() 2024-12-04 19:21:47 -08:00
gtp.c
ifb.c
loopback.c
macsec.c
macvlan.c ndo_fdb_del: Add a parameter to report whether notification was sent 2024-11-15 16:39:18 -08:00
macvtap.c
mdio.c mdio: Remove mdio45_ethtool_gset_npage() 2024-11-14 19:08:55 -08:00
mhi_net.c
mii.c
net_failover.c
netconsole.c
netkit.c rtnetlink: fix double call of rtnl_link_get_net_ifla() 2024-12-03 11:29:29 +01:00
nlmon.c
ntb_netdev.c
pfcp.c
rionet.c
sb1000.c
sungem_phy.c
tap.c
tun.c net: tun: fix tun_napi_alloc_frags() 2024-12-13 19:33:45 -08:00
veth.c rtnetlink: fix double call of rtnl_link_get_net_ifla() 2024-12-03 11:29:29 +01:00
virtio_net.c virtio_net: ensure netdev_tx_reset_queue is called on bind xsk for tx 2024-12-10 11:22:21 +01:00
vrf.c
vsockmon.c
xen-netfront.c xen/netfront: fix crash when removing device 2024-12-13 09:12:24 +01:00