mirror-linux/drivers/i2c
Benjamin Bara 08038069c2 i2c: core: Fix atomic xfer check for non-preempt config
commit a3368e1186 upstream.

Since commit aa49c90894 ("i2c: core: Run atomic i2c xfer when
!preemptible"), the whole reboot/power off sequence on non-preempt kernels
is using atomic i2c xfer, as !preemptible() always results to 1.

During device_shutdown(), the i2c might be used a lot and not all busses
have implemented an atomic xfer handler. This results in a lot of
avoidable noise, like:

[   12.687169] No atomic I2C transfer handler for 'i2c-0'
[   12.692313] WARNING: CPU: 6 PID: 275 at drivers/i2c/i2c-core.h:40 i2c_smbus_xfer+0x100/0x118
...

Fix this by allowing non-atomic xfer when the interrupts are enabled, as
it was before.

Link: https://lore.kernel.org/r/20231222230106.73f030a5@yea
Link: https://lore.kernel.org/r/20240102150350.3180741-1-mwalle@kernel.org
Link: https://lore.kernel.org/linux-i2c/13271b9b-4132-46ef-abf8-2c311967bb46@mailbox.org/
Fixes: aa49c90894 ("i2c: core: Run atomic i2c xfer when !preemptible")
Cc: stable@vger.kernel.org # v5.2+
Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com>
Tested-by: Michael Walle <mwalle@kernel.org>
Tested-by: Tor Vic <torvic9@mailbox.org>
[wsa: removed a comment which needs more work, code is ok]
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-01-10 17:10:35 +01:00
..
algos
busses i2c: aspeed: Handle the coalesced stop conditions with the start conditions. 2024-01-01 12:38:59 +00:00
muxes i2c: muxes: i2c-demux-pinctrl: Use of_get_i2c_adapter_by_node() 2023-11-02 09:35:30 +01:00
Kconfig
Makefile
i2c-boardinfo.c
i2c-core-acpi.c More ACPI updates for 6.1-rc1 2022-10-10 13:28:06 -07:00
i2c-core-base.c i2c: fix memleak in i2c_new_client_device() 2023-11-28 17:07:01 +00:00
i2c-core-of.c treewide: Fix probing of devices in DT overlays 2023-09-13 09:43:05 +02:00
i2c-core-slave.c
i2c-core-smbus.c
i2c-core.h i2c: core: Fix atomic xfer check for non-preempt config 2024-01-10 17:10:35 +01:00
i2c-dev.c i2c: dev: copy userspace array safely 2023-11-28 17:07:02 +00:00
i2c-mux.c i2c: mux: Avoid potential false error message in i2c_mux_add_adapter 2023-10-25 12:03:09 +02:00
i2c-slave-eeprom.c i2c: Make remove callback return void 2022-08-16 12:46:26 +02:00
i2c-slave-testunit.c i2c: Make remove callback return void 2022-08-16 12:46:26 +02:00
i2c-smbus.c i2c: Make remove callback return void 2022-08-16 12:46:26 +02:00
i2c-stub.c