mirror-linux/drivers/gpu/drm
Douglas Anderson cc2db2ef8d drm/panel: himax-hx8394: Handle errors from mipi_dsi_dcs_set_display_on() better
If mipi_dsi_dcs_set_display_on() returned an error then we'd store
that in the "ret" variable and jump to error handling. We'd then
attempt an orderly poweroff. Unfortunately we then blew away the value
stored in "ret". That means that if the orderly poweroff actually
worked then we're return 0 (no error) from hx8394_enable() even though
the panel wasn't enabled.

Fix this by not blowing away "ret".

Found by code inspection.

Fixes: 65dc9360f7 ("drm: panel: Add Himax HX8394 panel controller driver")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240517143643.1.I0a6836fffd8d7620f353becb3df2370d2898f803@changeid
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240517143643.1.I0a6836fffd8d7620f353becb3df2370d2898f803@changeid
2024-05-21 10:01:19 +02:00
..
amd drm/amdgpu: Use drm_crtc_vblank_crtc() 2024-05-08 21:55:30 +03:00
arm drm/arm/komeda: update DMA mask to 40 bits 2024-05-10 11:26:24 +01:00
armada drm/print: drop include debugfs.h and include where needed 2024-04-25 17:05:48 +03:00
aspeed
ast drm/ast: Use fbdev-shmem 2024-05-02 11:33:16 +02:00
atmel-hlcdc drm/atmel-hlcdc: Allow build with COMPILE_TEST=y 2024-05-08 22:09:06 +03:00
bridge drm/bridge: anx7625: use struct drm_edid more 2024-05-13 19:10:55 +02:00
ci drm: ci: fix the xfails for apq8016 2024-04-29 10:26:30 -03:00
display Core Changes: 2024-04-26 09:07:28 +10:00
etnaviv Revert "drm/etnaviv: Expose a few more chipspecs to userspace" 2024-04-25 16:56:20 +02:00
exynos gpu: drm: exynos: hdmi: eliminate uses of of_node_put() 2024-04-25 09:37:12 +09:00
fsl-dcu
gma500 drm/gma500: Fix spelling mistake "patter" -> "pattern" 2024-05-03 09:35:39 +02:00
gud drm/gud: Use fbdev-shmem 2024-05-02 11:33:17 +02:00
hisilicon drm/hisilicon/kirin: Allow build with COMPILE_TEST=y 2024-05-08 22:03:25 +03:00
hyperv drm/hyperv: Use fbdev-shmem 2024-05-02 11:33:17 +02:00
i2c drm/i2c: tda998x: switch to struct drm_edid 2024-05-13 19:10:57 +02:00
i915 Merge tag 'drm-intel-gt-next-2024-04-26' of https://anongit.freedesktop.org/git/drm/drm-intel into drm-next 2024-04-30 14:40:43 +10:00
imagination drm/print: drop include debugfs.h and include where needed 2024-04-25 17:05:48 +03:00
imx drm/imx/lcdc: Use fbdev-dma 2024-05-02 11:33:23 +02:00
ingenic drm/ingenic: Use fbdev-dma 2024-05-02 11:33:24 +02:00
kmb
lib
lima drm/lima: fix void pointer to enum lima_gpu_id cast warning 2024-04-15 09:06:27 +08:00
logicvc
loongson drm/fbdev-generic: Convert to fbdev-ttm 2024-05-02 11:33:32 +02:00
mcde
mediatek drm/mediatek: Use fbdev-dma 2024-05-02 11:33:24 +02:00
meson drm/meson: gate px_clk when setting rate 2024-04-22 18:54:24 +02:00
mgag200 drm/mgag200: Add an option to disable Write-Combine 2024-05-21 09:38:47 +02:00
msm drm/print: drop include debugfs.h and include where needed 2024-04-25 17:05:48 +03:00
mxsfb drm/lcdif: Do not disable clocks on already suspended hardware 2024-03-20 04:32:55 +01:00
nouveau drm/fbdev-generic: Convert to fbdev-ttm 2024-05-02 11:33:32 +02:00
omapdrm drm/omap: Allow build with COMPILE_TEST=y 2024-05-08 22:09:06 +03:00
panel drm/panel: himax-hx8394: Handle errors from mipi_dsi_dcs_set_display_on() better 2024-05-21 10:01:19 +02:00
panfrost Linux 6.9-rc5 2024-04-22 14:35:52 +10:00
panthor drm/panthor: clean up some types in panthor_sched_suspend() 2024-04-22 09:39:40 +02:00
pl111
qxl drm/fbdev-generic: Convert to fbdev-ttm 2024-05-02 11:33:32 +02:00
radeon drm/print: drop include debugfs.h and include where needed 2024-04-25 17:05:48 +03:00
renesas drm/rcar-du: Allow build with COMPILE_TEST=y 2024-05-08 22:09:06 +03:00
rockchip drm/rockchip: Use fbdev-dma 2024-05-02 11:33:27 +02:00
scheduler Merge drm/drm-fixes into drm-misc-fixes 2024-03-25 21:11:58 +01:00
solomon drm/solomon: Use fbdev-shmem 2024-05-02 11:33:18 +02:00
sprd
sti drm/print: drop include debugfs.h and include where needed 2024-04-25 17:05:48 +03:00
stm drm/stm: Allow build with COMPILE_TEST=y 2024-05-08 22:09:06 +03:00
sun4i drm/sun4i: hdmi: switch to struct drm_edid 2024-04-22 21:44:30 +03:00
tegra Merge drm/drm-next into drm-misc-next 2024-04-02 09:51:30 +02:00
tests drm/tests: Add a test case for drm buddy clear allocation 2024-04-22 19:44:16 +02:00
tidss drm/tidss: Use dev_err_probe() over dev_dbg() when failing to probe the port 2024-03-05 12:13:57 +01:00
tilcdc drm: tilcdc: don't use devm_pinctrl_get_select_default() in probe 2024-04-10 14:27:00 +03:00
tiny drm/bochs: switch to struct drm_edid 2024-05-13 19:12:36 +02:00
ttm drm/print: drop include debugfs.h and include where needed 2024-04-25 17:05:48 +03:00
tve200
udl drm/udl: Remove struct udl_connector 2024-05-13 13:35:53 +02:00
v3d drm/v3d: Use V3D_MAX_COUNTERS instead of V3D_PERFCNT_NUM 2024-05-20 16:38:03 -03:00
vboxvideo drm/fbdev-generic: Convert to fbdev-ttm 2024-05-02 11:33:32 +02:00
vc4 drm/print: drop include debugfs.h and include where needed 2024-04-25 17:05:48 +03:00
vgem
virtio drm/virtio: switch to struct drm_edid 2024-05-13 19:12:46 +02:00
vkms drm/vkms: Use fbdev-shmem 2024-05-02 11:33:22 +02:00
vmwgfx drm/fbdev-generic: Convert to fbdev-ttm 2024-05-02 11:33:32 +02:00
xe Merge tag 'drm-misc-next-2024-04-25' of https://gitlab.freedesktop.org/drm/misc/kernel into drm-next 2024-04-26 13:29:04 +10:00
xen
xlnx drm: xlnx: zynqmp_dpsub: Fix compilation error 2024-04-27 10:25:08 +03:00
Kconfig drm/panic: Add debugfs entry to test without triggering panic. 2024-04-15 16:13:15 +02:00
Makefile drm/fbdev-generic: Convert to fbdev-ttm 2024-05-02 11:33:32 +02:00
drm_aperture.c
drm_atomic.c
drm_atomic_helper.c drm/panic: Add drm panic locking 2024-04-15 16:11:26 +02:00
drm_atomic_state_helper.c
drm_atomic_uapi.c drm: prefer DRM_MODE_FMT/ARG over drm_mode_debug_printmodeline() 2024-04-15 16:22:50 +03:00
drm_auth.c
drm_blend.c
drm_bridge.c drm/drm-bridge: Drop conditionals around of_node pointers 2024-05-08 15:44:21 +02:00
drm_bridge_connector.c
drm_buddy.c drm/buddy: Implement tracking clear page feature 2024-04-22 19:44:16 +02:00
drm_cache.c
drm_client.c drm/client: Pin vmap'ed GEM buffers 2024-03-11 13:33:50 +01:00
drm_client_modeset.c Linux 6.9-rc5 2024-04-22 14:35:52 +10:00
drm_color_mgmt.c
drm_connector.c
drm_crtc.c drm: prefer DRM_MODE_FMT/ARG over drm_mode_debug_printmodeline() 2024-04-15 16:22:50 +03:00
drm_crtc_helper.c drm: prefer DRM_MODE_FMT/ARG over drm_mode_debug_printmodeline() 2024-04-15 16:22:50 +03:00
drm_crtc_helper_internal.h drm: avoid includes in drm_crtc_helper_internal.h 2024-03-11 11:47:07 +02:00
drm_crtc_internal.h drm/edid: rename drm_find_edid_extension() to drm_edid_find_extension() 2024-04-17 16:11:28 +03:00
drm_damage_helper.c
drm_debugfs.c drm/debugfs: Drop conditionals around of_node pointers 2024-05-01 09:06:46 -07:00
drm_debugfs_crc.c
drm_displayid.c drm/edid: rename drm_find_edid_extension() to drm_edid_find_extension() 2024-04-17 16:11:28 +03:00
drm_displayid_internal.h drm/edid: Parse topology block for all DispID structure v1.x 2024-04-22 11:38:11 +03:00
drm_drv.c drm: deprecate driver date 2024-05-08 15:31:58 +03:00
drm_dumb_buffers.c
drm_edid.c drm/edid: remove drm_do_get_edid() 2024-05-14 10:30:15 +03:00
drm_edid_load.c drm/edid/firmware: Remove built-in EDIDs 2024-02-26 14:05:18 +01:00
drm_eld.c drm/edid: move all internal declarations to drm_crtc_internal.h 2024-04-17 16:11:17 +03:00
drm_encoder.c
drm_encoder_slave.c
drm_exec.c
drm_fb_dma_helper.c drm/fb_dma: Add checks in drm_fb_dma_get_scanout_buffer() 2024-04-30 16:25:46 +02:00
drm_fb_helper.c drm/fbdev: Clean up fbdev documentation 2024-05-02 11:33:34 +02:00
drm_fbdev_dma.c drm/fbdev-dma: Clean up deferred I/O 2024-05-15 14:50:20 +02:00
drm_fbdev_shmem.c drm/fbdev-shmem: Clean up deferred I/O 2024-05-15 14:50:46 +02:00
drm_fbdev_ttm.c drm/fbdev-generic: Convert to fbdev-ttm 2024-05-02 11:33:32 +02:00
drm_file.c
drm_flip_work.c
drm_format_helper.c
drm_fourcc.c
drm_framebuffer.c
drm_gem.c drm/fbdev-generic: Fix locking with drm_client_buffer_vmap_local() 2024-03-11 13:33:50 +01:00
drm_gem_atomic_helper.c drm/atomic-helper: fix parameter order in drm_format_conv_state_copy() call 2024-04-19 17:36:49 +02:00
drm_gem_dma_helper.c
drm_gem_framebuffer_helper.c
drm_gem_shmem_helper.c drm/shmem-helper: Remove duplicate include 2024-03-12 16:43:19 +01:00
drm_gem_ttm_helper.c
drm_gem_vram_helper.c Merge drm/drm-next into drm-misc-next 2024-04-02 09:51:30 +02:00
drm_gpuvm.c
drm_internal.h drm/edid: move all internal declarations to drm_crtc_internal.h 2024-04-17 16:11:17 +03:00
drm_ioc32.c
drm_ioctl.c drm: use "0" instead of "" for deprecated driver date 2024-05-10 20:56:12 +03:00
drm_kms_helper_common.c
drm_lease.c
drm_managed.c
drm_mipi_dbi.c
drm_mipi_dsi.c drm/mipi-dsi: wrap more functions for streamline handling 2024-05-17 21:36:19 +02:00
drm_mm.c
drm_mode_config.c drm: Introduce plane SIZE_HINTS property 2024-04-11 18:28:58 +03:00
drm_mode_object.c
drm_modes.c drm: prefer DRM_MODE_FMT/ARG over drm_mode_debug_printmodeline() 2024-04-15 16:22:50 +03:00
drm_modeset_helper.c drm: Check output polling initialized before disabling 2024-02-28 15:07:15 +01:00
drm_modeset_lock.c
drm_of.c
drm_panel.c drm/panel: do not return negative error codes from drm_panel_get_modes() 2024-03-13 10:44:14 +02:00
drm_panel_orientation_quirks.c
drm_panic.c drm/panic: Add debugfs entry to test without triggering panic. 2024-04-15 16:13:15 +02:00
drm_pci.c
drm_plane.c drm: Fix plane SIZE_HINTS property docs 2024-04-22 11:42:32 +03:00
drm_plane_helper.c
drm_prime.c drm/prime: Unbreak virtgpu dma-buf export 2024-03-28 19:52:22 +01:00
drm_print.c drm/print: drop include debugfs.h and include where needed 2024-04-25 17:05:48 +03:00
drm_privacy_screen.c
drm_privacy_screen_x86.c
drm_probe_helper.c drm: prefer DRM_MODE_FMT/ARG over drm_mode_debug_printmodeline() 2024-04-15 16:22:50 +03:00
drm_property.c
drm_rect.c
drm_self_refresh_helper.c
drm_simple_kms_helper.c
drm_suballoc.c
drm_syncobj.c Linux 6.8-rc6 2024-02-26 11:41:07 +01:00
drm_sysfs.c drm/sysfs: switch to drm device based logging 2024-04-15 16:22:05 +03:00
drm_trace.h
drm_trace_points.c
drm_vblank.c drm/vblank: Introduce drm_crtc_vblank_crtc() 2024-04-18 13:27:56 +03:00
drm_vblank_work.c drm/vblank: Introduce drm_crtc_vblank_crtc() 2024-04-18 13:27:56 +03:00
drm_vma_manager.c
drm_writeback.c