Hans de Goede bd100f492c platform/x86: apple-gmux: Add apple_gmux_detect() helper ... [ Upstream commit d143908f80 ] Add a new (static inline) apple_gmux_detect() helper to apple-gmux.h which can be used for gmux detection instead of apple_gmux_present(). The latter is not really reliable since an ACPI device with a HID of APP000B is present on some devices without a gmux at all, as well as on devices with a newer (unsupported) MMIO based gmux model. This causes apple_gmux_present() to return false-positives on a number of different Apple laptop models. This new helper uses the same probing as the actual apple-gmux driver, so that it does not return false positives. To avoid code duplication the gmux_probe() function of the actual driver is also moved over to using the new apple_gmux_detect() helper. This avoids false positives (vs _HID + IO region detection) on: MacBookPro5,4 https://pastebin.com/8Xjq7RhS MacBookPro8,1 https://linux-hardware.org/?probe=e513cfbadb&log=dmesg MacBookPro9,2 https://bugzilla.kernel.org/attachment.cgi?id=278961 MacBookPro10,2 https://lkml.org/lkml/2014/9/22/657 MacBookPro11,2 https://forums.fedora-fr.org/viewtopic.php?id=70142 MacBookPro11,4 https://raw.githubusercontent.com/im-0/investigate-card-reader-suspend-problem-on-mbp11.4/master/test-16/dmesg Fixes: 21245df307 ("ACPI: video: Add Apple GMUX brightness control detection") Link: https://lore.kernel.org/platform-driver-x86/20230123113750.462144-1-hdegoede@redhat.com/ Reported-by: Emmanouil Kouroupakis <kartebi@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20230124105754.62167-3-hdegoede@redhat.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-02-01 08:34:46 +01:00
..
chrome	platform/chrome: cros_ec_typec: zero out stale pointers	2022-12-31 13:32:00 +01:00
goldfish	platform: goldfish: pipe: Use platform_get_irq() to get the interrupt	2022-03-18 13:55:21 +01:00
loongarch	platform/loongarch: laptop: Fix possible UAF and simplify generic_acpi_laptop_init()	2022-10-29 16:29:31 +08:00
mellanox	platform/mellanox: mlxbf-pmc: Fix event typo	2022-12-31 13:32:01 +01:00
mips	MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error.	2022-06-09 22:24:19 +02:00
olpc	platform/olpc: Fix uninitialized data in debugfs write	2022-07-28 20:40:15 +02:00
surface	platform/surface: aggregator: Add missing call to ssam_request_sync_free()	2023-01-18 11:58:32 +01:00
x86	platform/x86: apple-gmux: Add apple_gmux_detect() helper	2023-02-01 08:34:46 +01:00
Kconfig	LoongArch: Add ACPI-based generic laptop driver	2022-10-12 16:36:20 +08:00
Makefile	LoongArch: Add ACPI-based generic laptop driver	2022-10-12 16:36:20 +08:00