Arnd Bergmann d18539754d scsi: aacraid: address UBSAN warning regression ... As reported by Meelis Roos, my previous patch causes an incorrect calculation of the timeout, through an undefined signed integer overflow: [ 12.228155] UBSAN: Undefined behaviour in drivers/scsi/aacraid/commsup.c:2514:49 [ 12.228229] signed integer overflow: [ 12.228283] 964297611 * 250 cannot be represented in type 'long int' The problem is that doing a multiplication with HZ first and then dividing by USEC_PER_SEC worked correctly for 32-bit microseconds, but not for 32-bit nanoseconds, which would require up to 41 bits. This reworks the calculation to first convert the nanoseconds into jiffies, which should give us the same result as before and not overflow. Unfortunately I did not understand the exact intention of the algorithm, in particular the part where we add half a second, so it's possible that there is still a preexisting problem in this function. I added a comment that this would be handled more nicely using usleep_range(), which generally works better for waking up at a particular time than the current schedule_timeout() based implementation. I did not feel comfortable trying to implement that without being sure what the intent is here though. Fixes: 820f188659 ("scsi: aacraid: use timespec64 instead of timeval") Tested-by: Meelis Roos <mroos@linux.ee> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>		2017-11-29 00:07:20 -05:00
..
accessibility	…
acpi	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
amba	A couple of dma-mapping updates:	2017-11-14 16:54:12 -08:00
android	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
ata	Merge branch 'for-4.15' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata	2017-11-15 14:11:41 -08:00
atm	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-11-15 11:56:19 -08:00
auxdisplay	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-13 17:56:58 -08:00
base	DeviceTree for 4.15:	2017-11-14 18:25:40 -08:00
bcma	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-11-15 11:56:19 -08:00
block	A couple of dma-mapping updates:	2017-11-14 16:54:12 -08:00
bluetooth	…
bus	arm64 updates for 4.15	2017-11-15 10:56:56 -08:00
cdrom	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
char	IPMI updates for 4.15	2017-11-15 15:12:28 -08:00
clk	…
clocksource	arm64 updates for 4.15	2017-11-15 10:56:56 -08:00
connector	…
cpufreq	Power management updates for v4.15-rc1	2017-11-13 19:43:50 -08:00
cpuidle	Merge branch 'pm-cpuidle'	2017-11-13 01:34:14 +01:00
crypto	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2017-11-14 10:52:09 -08:00
dax	…
dca	…
devfreq	Merge branches 'pm-devfreq' and 'pm-tools'	2017-11-13 01:41:39 +01:00
dio	…
dma	dmaengine updates for 4.15-rc1	2017-11-14 16:49:31 -08:00
dma-buf	…
edac	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
eisa	…
extcon	USB/PHY patches for 4.15-rc1	2017-11-13 21:14:07 -08:00
firewire	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-13 17:56:58 -08:00
firmware	…
fmc	…
fpga	…
fsi	…
gpio	Merge branch 'i2c/for-4.15' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/wsa/linux	2017-11-14 17:52:21 -08:00
gpu	DeviceTree for 4.15:	2017-11-14 18:25:40 -08:00
hid	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
hsi	HSI changes for the v4.15 series	2017-11-15 13:35:43 -08:00
hv	x86/virt: Add enum for hypervisors to replace x86_hyper	2017-11-10 10:03:12 +01:00
hwmon	hwmon updates for v4.15	2017-11-13 08:55:46 -08:00
hwspinlock	…
hwtracing	A couple of configfs cleanups:	2017-11-14 14:44:04 -08:00
i2c	Merge branch 'i2c/for-4.15' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/wsa/linux	2017-11-14 17:52:21 -08:00
ide	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
idle	Merge branch 'pm-cpuidle'	2017-11-13 01:34:14 +01:00
iio	A couple of configfs cleanups:	2017-11-14 14:44:04 -08:00
infiniband	Updates for 4.15 kernel merge window	2017-11-15 14:54:53 -08:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2017-11-14 18:07:18 -08:00
iommu	IOMMU Updates for Linux v4.15	2017-11-14 16:43:27 -08:00
ipack	…
irqchip	pci-v4.15-changes	2017-11-15 15:01:28 -08:00
isdn	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
leds	LED updates for 4.15rc1	2017-11-14 18:09:31 -08:00
lightnvm	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
macintosh	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-13 17:56:58 -08:00
mailbox	Change to POLL api and fixes for FlexRM and OMAP driver	2017-11-15 13:39:18 -08:00
mcb	…
md	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
media	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
memory	…
memstick	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-13 17:56:58 -08:00
message	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
mfd	sound updates for 4.15-rc1	2017-11-14 18:01:46 -08:00
misc	pci-v4.15-changes	2017-11-15 15:01:28 -08:00
mmc	MMC core:	2017-11-13 10:17:35 -08:00
mtd	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
mux	…
net	Updates for 4.15 kernel merge window	2017-11-15 14:54:53 -08:00
nfc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-11-15 11:56:19 -08:00
ntb	…
nubus	m68k updates for 4.15	2017-11-13 12:10:24 -08:00
nvdimm	Merge branch 'for-linus' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2017-11-15 10:14:11 -08:00
nvme	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
nvmem	…
of	pci-v4.15-changes	2017-11-15 15:01:28 -08:00
opp	…
oprofile	…
parisc	…
parport	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-13 17:56:58 -08:00
pci	pci-v4.15-changes	2017-11-15 15:01:28 -08:00
pcmcia	pci-v4.15-changes	2017-11-15 15:01:28 -08:00
perf	arm64 updates for 4.15	2017-11-15 10:56:56 -08:00
phy	USB/PHY patches for 4.15-rc1	2017-11-13 21:14:07 -08:00
pinctrl	This is the bulk of GPIO changes for the v4.15 kernel cycle:	2017-11-14 17:23:44 -08:00
platform	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
pnp	…
power	power supply and reset changes for the v4.15 series	2017-11-15 13:37:15 -08:00
powercap	…
pps	…
ps3	…
ptp	…
pwm	…
rapidio	…
ras	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-13 17:56:58 -08:00
regulator	MMC core:	2017-11-13 10:17:35 -08:00
remoteproc	…
reset	…
rpmsg	…
rtc	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-13 17:56:58 -08:00
s390	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-11-15 11:56:19 -08:00
sbus	…
scsi	scsi: aacraid: address UBSAN warning regression	2017-11-29 00:07:20 -05:00
sfi	…
sh	A couple of dma-mapping updates:	2017-11-14 16:54:12 -08:00
sn	…
soc	USB/PHY patches for 4.15-rc1	2017-11-13 21:14:07 -08:00
spi	Merge remote-tracking branches 'spi/topic/sh-msiof', 'spi/topic/slave', 'spi/topic/spreadtrum' and 'spi/topic/tegra114' into spi-next	2017-11-10 21:33:51 +00:00
spmi	…
ssb	…
staging	Updates for 4.15 kernel merge window	2017-11-15 14:54:53 -08:00
target	A couple of configfs cleanups:	2017-11-14 14:44:04 -08:00
tc	…
tee	…
thermal	…
thunderbolt	…
tty	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
uio	…
usb	sound updates for 4.15-rc1	2017-11-14 18:01:46 -08:00
uwb	…
vfio	VFIO Updates for Linux v4.15	2017-11-14 16:47:47 -08:00
vhost	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-11-15 11:56:19 -08:00
video	…
virt	…
virtio	…
vlynq	…
vme	…
w1	…
watchdog	MIPS changes for 4.15	2017-11-15 11:36:08 -08:00
xen	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-13 17:56:58 -08:00
zorro	…
Kconfig	Merge branches 'pm-cpufreq-sched' and 'pm-opp'	2017-11-13 01:40:52 +01:00
Makefile	Merge branches 'pm-cpufreq-sched' and 'pm-opp'	2017-11-13 01:40:52 +01:00