mirror-linux/drivers/i2c
Gregor Herburger 8f09ece19c i2c: ocores: generate stop condition after timeout in polling mode
[ Upstream commit f8160d3b35 ]

In polling mode, no stop condition is generated after a timeout. This
causes SCL to remain low and thereby block the bus. If this happens
during a transfer it can cause slaves to misinterpret the subsequent
transfer and return wrong values.

To solve this, pass the ETIMEDOUT error up from ocores_process_polling()
instead of setting STATE_ERROR directly. The caller is adjusted to call
ocores_process_timeout() on error both in polling and in IRQ mode, which
will set STATE_ERROR and generate a stop condition.

Fixes: 69c8c0c0ef ("i2c: ocores: add polling interface")
Signed-off-by: Gregor Herburger <gregor.herburger@tq-group.com>
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Acked-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Federico Vaga <federico.vaga@cern.ch>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-04-20 12:35:14 +02:00
..
algos
busses i2c: ocores: generate stop condition after timeout in polling mode 2023-04-20 12:35:14 +02:00
muxes i2c: mux: reg: check return value after calling platform_get_resource() 2022-12-31 13:32:42 +01:00
Kconfig
Makefile
i2c-boardinfo.c
i2c-core-acpi.c More ACPI updates for 6.1-rc1 2022-10-10 13:28:06 -07:00
i2c-core-base.c i2c: Restore initial power state if probe fails 2022-11-14 20:46:31 +01:00
i2c-core-of.c
i2c-core-slave.c i2c: add tracepoints for I2C slave events 2022-03-20 00:11:05 +01:00
i2c-core-smbus.c i2c: smbus: Check for parent device before dereference 2022-02-19 12:37:20 +01:00
i2c-core.h i2c: acpi: Use ACPI wake capability bit to set wake_irq 2022-10-04 15:41:12 +02:00
i2c-dev.c i2c: dev: Force case user pointers in compat_i2cdev_ioctl() 2022-04-15 23:30:59 +02:00
i2c-mux.c i2c: mux: harden i2c_mux_alloc() against integer overflows 2022-09-21 22:12:06 +02:00
i2c-slave-eeprom.c i2c: Make remove callback return void 2022-08-16 12:46:26 +02:00
i2c-slave-testunit.c i2c: Make remove callback return void 2022-08-16 12:46:26 +02:00
i2c-smbus.c i2c: Make remove callback return void 2022-08-16 12:46:26 +02:00
i2c-stub.c