Speakup exposing a line discipline allows userland to try to use it, while it is deemed to be useless, and thus uselessly exposes potential bugs. One of them is simply that in such a case if the line sends data, spk_ttyio_receive_buf2 is called and crashes since spk_ttyio_synth is NULL. This change restricts the use of the speakup line discipline to speakup drivers, thus avoiding such kind of issues altogether. Cc: stable@vger.kernel.org Reported-by: Shisong Qin <qinshisong1205@gmail.com> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org> Tested-by: Shisong Qin <qinshisong1205@gmail.com> Link: https://lore.kernel.org/r/20201129193523.hm3f6n5xrn6fiyyc@function Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
||
|---|---|---|
| .. | ||
| DefaultKeyAssignments | ||
| Kconfig | ||
| Makefile | ||
| TODO | ||
| buffers.c | ||
| devsynth.c | ||
| fakekey.c | ||
| i18n.c | ||
| i18n.h | ||
| keyhelp.c | ||
| kobjects.c | ||
| main.c | ||
| selection.c | ||
| serialio.c | ||
| serialio.h | ||
| speakup.h | ||
| speakup_acnt.h | ||
| speakup_acntpc.c | ||
| speakup_acntsa.c | ||
| speakup_apollo.c | ||
| speakup_audptr.c | ||
| speakup_bns.c | ||
| speakup_decext.c | ||
| speakup_decpc.c | ||
| speakup_dectlk.c | ||
| speakup_dtlk.c | ||
| speakup_dtlk.h | ||
| speakup_dummy.c | ||
| speakup_keypc.c | ||
| speakup_ltlk.c | ||
| speakup_soft.c | ||
| speakup_spkout.c | ||
| speakup_txprt.c | ||
| speakupmap.h | ||
| speakupmap.map | ||
| spk_priv.h | ||
| spk_priv_keyinfo.h | ||
| spk_ttyio.c | ||
| spk_types.h | ||
| synth.c | ||
| thread.c | ||
| varhandlers.c | ||