superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
mirror-linux/drivers/bluetooth
History
Kuba Pawlak f6fc86f2c5 Bluetooth: Fix possible deadlock in btusb 
commit 8f9d02f470 introduced spinlocks
in btusb_work. This is run in a context of a worqueue and can be interrupted
by hardware irq. If it happens while spinlock is held, we have a deadlock.
Solution is to use _irqsave/_resore version of locking

[  466.460560] =================================
[  466.460565] [ INFO: inconsistent lock state ]
[  466.460572] 4.3.0-rc6+ #1 Tainted: G        W
[  466.460576] ---------------------------------
[  466.460582] inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage.
[  466.460589] kworker/0:2/94 [HC0[0]:SC0[0]:HE1:SE1] takes:
[  466.460595]  (&(&data->rxlock)->rlock){?.-...}, at: [<ffffffffa0526923>] btusb_work+0xa3/0x3fd [btusb]
[  466.460621] {IN-HARDIRQ-W} state was registered at:
[  466.460625]   [<ffffffff811021b5>] __lock_acquire+0xc45/0x1e80
[  466.460638]   [<ffffffff811040d5>] lock_acquire+0xe5/0x1f0
[  466.460646]   [<ffffffff8182f108>] _raw_spin_lock+0x38/0x50
[  466.460657]   [<ffffffffa0525448>] btusb_recv_intr+0x38/0x170 [btusb]
[  466.460668]   [<ffffffffa0525626>] btusb_intr_complete+0xa6/0x130 [btusb]
[  466.460679]   [<ffffffff815d8f1e>] __usb_hcd_giveback_urb+0x8e/0x160
[  466.460690]   [<ffffffff815d911f>] usb_hcd_giveback_urb+0x3f/0x120
[  466.460698]   [<ffffffff81606e4d>] uhci_giveback_urb+0xad/0x280
[  466.460706]   [<ffffffff81608f64>] uhci_scan_schedule.part.33+0x6b4/0xbe0
[  466.460714]   [<ffffffff81609b50>] uhci_irq+0xd0/0x180
[  466.460722]   [<ffffffff815d8296>] usb_hcd_irq+0x26/0x40
[  466.460729]   [<ffffffff81117d40>] handle_irq_event_percpu+0x40/0x300
[  466.460739]   [<ffffffff81118040>] handle_irq_event+0x40/0x60
[  466.460746]   [<ffffffff8111af39>] handle_fasteoi_irq+0x89/0x150
[  466.460754]   [<ffffffff8101e0f3>] handle_irq+0x73/0x120
[  466.460763]   [<ffffffff81832f11>] do_IRQ+0x61/0x120
[  466.460772]   [<ffffffff8183084c>] ret_from_intr+0x0/0x31
[  466.460780]   [<ffffffff81697a77>] cpuidle_enter+0x17/0x20
[  466.460790]   [<ffffffff810f62c2>] call_cpuidle+0x32/0x60
[  466.460800]   [<ffffffff810f65a8>] cpu_startup_entry+0x2b8/0x3f0
[  466.460807]   [<ffffffff818214ca>] rest_init+0x13a/0x140
[  466.460817]   [<ffffffff81f76029>] start_kernel+0x4a3/0x4c4
[  466.460827]   [<ffffffff81f75339>] x86_64_start_reservations+0x2a/0x2c
[  466.460837]   [<ffffffff81f75485>] x86_64_start_kernel+0x14a/0x16d
[  466.460846] irq event stamp: 754913
[  466.460851] hardirqs last  enabled at (754913): [<ffffffff8182f4cc>] _raw_spin_unlock_irq+0x2c/0x40
[  466.460861] hardirqs last disabled at (754912): [<ffffffff8182f28d>] _raw_spin_lock_irq+0x1d/0x60
[  466.460869] softirqs last  enabled at (753024): [<ffffffff810aeaa0>] __do_softirq+0x380/0x490
[  466.460880] softirqs last disabled at (753009): [<ffffffff810aedef>] irq_exit+0x10f/0x120
[  466.460888]
               other info that might help us debug this:
[  466.460894]  Possible unsafe locking scenario:

[  466.460899]        CPU0
[  466.460903]        ----
[  466.460907]   lock(&(&data->rxlock)->rlock);
[  466.460915]   <Interrupt>
[  466.460918]     lock(&(&data->rxlock)->rlock);
[  466.460926]
                *** DEADLOCK ***

[  466.460935] 2 locks held by kworker/0:2/94:
[  466.460939]  #0:  ("events"){.+.+.+}, at: [<ffffffff810c69bb>] process_one_work+0x16b/0x660
[  466.460958]  #1:  ((&data->work)){+.+...}, at: [<ffffffff810c69bb>] process_one_work+0x16b/0x660
[  466.460974]

Signed-off-by: Kuba Pawlak <kubax.t.pawlak@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
 		2015-11-05 04:03:11 +01:00
..
Kconfig Bluetooth: bpa10x: fix BT_HCIUART dependency 2015-10-21 00:49:22 +02:00
Makefile Bluetooth: hciuart: Add support QCA chipset for UART 2015-08-10 23:52:20 +02:00
ath3k.c Bluetooth: ath3k: Add support of AR3012 0cf3:817b device 2015-10-21 00:49:23 +02:00
bcm203x.c
…
bfusb.c Bluetooth: Move handling of HCI_RUNNING flag into core 2015-10-05 10:30:25 +03:00
bluecard_cs.c Bluetooth: Move handling of HCI_RUNNING flag into core 2015-10-05 10:30:25 +03:00
bpa10x.c Bluetooth: bpa10x: Use h4_recv_buf helper for frame reassembly 2015-10-08 10:04:27 +03:00
bt3c_cs.c Bluetooth: Move handling of HCI_RUNNING flag into core 2015-10-05 10:30:25 +03:00
btbcm.c Bluetooth: btbcm: Read USB product information for Apple devices 2015-10-21 00:49:23 +02:00
btbcm.h Bluetooth: btbcm: Support the BCM4354 Bluetooth UART device 2015-06-17 18:56:53 +02:00
btintel.c Bluetooth: btintel: Enable extra Intel vendor events 2015-10-21 07:34:11 +03:00
btintel.h Bluetooth: btintel: Enable extra Intel vendor events 2015-10-21 07:34:11 +03:00
btmrvl_debugfs.c Bluetooth: btmrvl add firmware dump support 2014-12-03 17:35:51 +01:00
btmrvl_drv.h Bluetooth: btmrvl: Coding style Fix for btmrvl header 2015-07-27 10:30:32 +03:00
btmrvl_main.c Bluetooth: btmrvl: add missing of_node_put 2015-10-25 21:03:29 +01:00
btmrvl_sdio.c Bluetooth: btmrvl: Comparison to NULL re-written 2015-09-25 21:39:04 +02:00
btmrvl_sdio.h Bluetooth: btmrvl add firmware dump support 2014-12-03 17:35:51 +01:00
btqca.c Bluetooth: btqca: Introduce generic QCA ROME support 2015-08-10 23:52:20 +02:00
btqca.h Bluetooth: btqca: Introduce generic QCA ROME support 2015-08-10 23:52:20 +02:00
btrtl.c Bluetooth: btrtl: Create separate module for Realtek BT driver 2015-05-14 12:04:12 +02:00
btrtl.h Bluetooth: btrtl: Create separate module for Realtek BT driver 2015-05-14 12:04:12 +02:00
btsdio.c Bluetooth: Move handling of HCI_RUNNING flag into core 2015-10-05 10:30:25 +03:00
btuart_cs.c Bluetooth: Move handling of HCI_RUNNING flag into core 2015-10-05 10:30:25 +03:00
btusb.c Bluetooth: Fix possible deadlock in btusb 2015-11-05 04:03:11 +01:00
btwilink.c Bluetooth: Move handling of HCI_RUNNING flag into core 2015-10-05 10:30:25 +03:00
dtl1_cs.c Bluetooth: Move handling of HCI_RUNNING flag into core 2015-10-05 10:30:25 +03:00
hci_ath.c Bluetooth: hci_uart: Provide initial manufacturer information 2015-10-21 07:20:44 +03:00
hci_bcm.c Bluetooth: hci_bcm: checking for ERR_PTR instead of NULL 2015-10-22 11:32:47 +02:00
hci_bcsp.c Bluetooth: hci_bcsp: Clean up code Fix 2015-06-09 13:59:09 +02:00
hci_h4.c Bluetooth: bpa10x: Use h4_recv_buf helper for frame reassembly 2015-10-08 10:04:27 +03:00
hci_h5.c Bluetooth: hci_h5: clean up hci_h5 code 2015-09-30 16:12:17 +02:00
hci_intel.c Bluetooth: hci_uart: Provide initial manufacturer information 2015-10-21 07:20:44 +03:00
hci_ldisc.c Bluetooth: hci_uart: Provide initial manufacturer information 2015-10-21 07:20:44 +03:00
hci_ll.c Bluetooth: hci_uart: Remove the manual protocol init message 2015-04-07 18:47:10 +02:00
hci_qca.c Bluetooth: hci_uart: Provide initial manufacturer information 2015-10-21 07:20:44 +03:00
hci_uart.h Bluetooth: hci_uart: Provide initial manufacturer information 2015-10-21 07:20:44 +03:00
hci_vhci.c Bluetooth: Move handling of HCI_RUNNING flag into core 2015-10-05 10:30:25 +03:00