mirror-linux/net/bridge
Antoine Tenart d01ed3240b netfilter: br_netfilter: remove unused conditional and dead code
The SKB_DROP_REASON_IP_INADDRERRORS drop reason is never returned from
any function, as such it cannot be returned from the ip_route_input call
tree. The 'reason != SKB_DROP_REASON_IP_INADDRERRORS' conditional is
thus always true.

Looking back at history, commit 50038bf38e ("net: ip: make
ip_route_input() return drop reasons") changed the ip_route_input
returned value check in br_nf_pre_routing_finish from -EHOSTUNREACH to
SKB_DROP_REASON_IP_INADDRERRORS. It turns out -EHOSTUNREACH could not be
returned either from the ip_route_input call tree and this since commit
251da41301 ("ipv4: Cache ip_error() routes even when not
forwarding.").

Not a fix as this won't change the behavior. While at it use
kfree_skb_reason.

Signed-off-by: Antoine Tenart <atenart@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2025-01-19 16:41:52 +01:00
..
netfilter
Kconfig
Makefile
br.c net: bridge: Handle changes in VLAN_FLAG_BRIDGE_BINDING 2024-12-20 13:14:17 -08:00
br_arp_nd_proxy.c bridge: Make br_is_nd_neigh_msg() accept pointer to "const struct sk_buff" 2025-01-07 15:13:10 +01:00
br_cfm.c
br_cfm_netlink.c
br_device.c netpoll: remove ndo_netpoll_setup() second argument 2024-10-23 13:31:32 +02:00
br_fdb.c rtnetlink: add ndo_fdb_dump_context 2024-12-10 18:32:32 -08:00
br_forward.c net: bridge: add skb drop reasons to the most common drop points 2024-12-23 10:11:04 -08:00
br_if.c
br_input.c net: bridge: add skb drop reasons to the most common drop points 2024-12-23 10:11:04 -08:00
br_ioctl.c
br_mdb.c
br_mrp.c
br_mrp_netlink.c
br_mrp_switchdev.c
br_mst.c
br_multicast.c
br_multicast_eht.c
br_netfilter_hooks.c netfilter: br_netfilter: remove unused conditional and dead code 2025-01-19 16:41:52 +01:00
br_netfilter_ipv6.c
br_netlink.c rtnetlink: Return int from rtnl_af_register(). 2024-10-22 11:02:05 +02:00
br_netlink_tunnel.c
br_nf_core.c
br_private.h bridge: Make br_is_nd_neigh_msg() accept pointer to "const struct sk_buff" 2025-01-07 15:13:10 +01:00
br_private_cfm.h
br_private_mcast_eht.h
br_private_mrp.h
br_private_stp.h
br_private_tunnel.h
br_stp.c
br_stp_bpdu.c
br_stp_if.c
br_stp_timer.c
br_switchdev.c
br_sysfs_br.c net: bridge: constify 'struct bin_attribute' 2024-12-17 19:00:43 -08:00
br_sysfs_if.c
br_vlan.c net: bridge: Handle changes in VLAN_FLAG_BRIDGE_BINDING 2024-12-20 13:14:17 -08:00
br_vlan_options.c
br_vlan_tunnel.c