superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
mirror-linux/drivers/net/ethernet/broadcom/bnxt
History
Michael Chan 4611d88a37 bnxt_en: Fix lockdep warning during rmmod 
The commit under the Fixes tag added a netdev_assert_locked() in
bnxt_free_ntp_fltrs().  The lock should be held during normal run-time
but the assert will be triggered (see below) during bnxt_remove_one()
which should not need the lock.  The netdev is already unregistered by
then.  Fix it by calling netdev_assert_locked_or_invisible() which will
not assert if the netdev is unregistered.

WARNING: CPU: 5 PID: 2241 at ./include/net/netdev_lock.h:17 bnxt_free_ntp_fltrs+0xf8/0x100 [bnxt_en]
Modules linked in: rpcrdma rdma_cm iw_cm ib_cm configfs ib_core bnxt_en(-) bridge stp llc x86_pkg_temp_thermal xfs tg3 [last unloaded: bnxt_re]
CPU: 5 UID: 0 PID: 2241 Comm: rmmod Tainted: G S      W           6.16.0 #2 PREEMPT(voluntary)
Tainted: [S]=CPU_OUT_OF_SPEC, [W]=WARN
Hardware name: Dell Inc. PowerEdge R730/072T6D, BIOS 2.4.3 01/17/2017
RIP: 0010:bnxt_free_ntp_fltrs+0xf8/0x100 [bnxt_en]
Code: 41 5c 41 5d 41 5e 41 5f c3 cc cc cc cc 48 8b 47 60 be ff ff ff ff 48 8d b8 28 0c 00 00 e8 d0 cf 41 c3 85 c0 0f 85 2e ff ff ff <0f> 0b e9 27 ff ff ff 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90
RSP: 0018:ffffa92082387da0 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffff9e5b593d8000 RCX: 0000000000000001
RDX: 0000000000000001 RSI: ffffffff83dc9a70 RDI: ffffffff83e1a1cf
RBP: ffff9e5b593d8c80 R08: 0000000000000000 R09: ffffffff8373a2b3
R10: 000000008100009f R11: 0000000000000001 R12: 0000000000000001
R13: ffffffffc01c4478 R14: dead000000000122 R15: dead000000000100
FS:  00007f3a8a52c740(0000) GS:ffff9e631ad1c000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055bb289419c8 CR3: 000000011274e001 CR4: 00000000003706f0
Call Trace:
 <TASK>
 bnxt_remove_one+0x57/0x180 [bnxt_en]
 pci_device_remove+0x39/0xc0
 device_release_driver_internal+0xa5/0x130
 driver_detach+0x42/0x90
 bus_remove_driver+0x61/0xc0
 pci_unregister_driver+0x38/0x90
 bnxt_exit+0xc/0x7d0 [bnxt_en]

Fixes: 004b500801 ("eth: bnxt: remove most dependencies on RTNL")
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20250816183850.4125033-1-michael.chan@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
 		2025-08-18 17:51:22 -07:00
..
Makefile
…
bnxt.c bnxt_en: Fix lockdep warning during rmmod 2025-08-18 17:51:22 -07:00
bnxt.h Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2025-05-01 15:11:38 -07:00
bnxt_coredump.c bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_coredump.h
…
bnxt_dcb.c bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_dcb.h
…
bnxt_debugfs.c bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_debugfs.h bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_devlink.c bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_devlink.h bnxt_en: Add devlink support for ENABLE_ROCE nvm parameter 2025-03-18 10:25:22 +01:00
bnxt_dim.c bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_ethtool.c bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_ethtool.h
…
bnxt_fw_hdr.h
…
bnxt_hwmon.c bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_hwmon.h
…
bnxt_hwrm.c bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_hwrm.h bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_nvm_defs.h
…
bnxt_ptp.c Networking changes for 6.17. 2025-07-30 08:58:55 -07:00
bnxt_ptp.h bnxt_en: improve TX timestamping FIFO configuration 2025-04-25 18:47:16 -07:00
bnxt_sriov.c net: Fix typos 2025-07-25 10:29:07 -07:00
bnxt_sriov.h
…
bnxt_tc.c bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_tc.h
…
bnxt_ulp.c bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_ulp.h bnxt_en: Remove unused macros in bnxt_ulp.h 2025-04-21 18:50:34 -07:00
bnxt_vfr.c bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_vfr.h
…
bnxt_xdp.c bnxt: move bnxt_hsi.h to include/linux/bnxt/hsi.h 2025-07-15 16:03:24 -07:00
bnxt_xdp.h eth: bnxt: do not update checksum in bnxt_xdp_build_skb() 2025-03-10 13:31:11 -07:00