mirror-linux/drivers/pinctrl/qcom
Bartosz Golaszewski 93712205ce pinctrl: qcom: msm: mark certain pins as invalid for interrupts
On some platforms, the UFS-reset pin has no interrupt logic in TLMM but
is nevertheless registered as a GPIO in the kernel. This enables the
user-space to trigger a BUG() in the pinctrl-msm driver by running, for
example: `gpiomon -c 0 113` on RB2.

The exact culprit is requesting pins whose intr_detection_width setting
is not 1 or 2 for interrupts. This hits a BUG() in
msm_gpio_irq_set_type(). Potentially crashing the kernel due to an
invalid request from user-space is not optimal, so let's go through the
pins and mark those that would fail the check as invalid for the irq chip
as we should not even register them as available irqs.

This function can be extended if we determine that there are more
corner-cases like this.

Fixes: f365be0925 ("pinctrl: Add Qualcomm TLMM driver")
Cc: stable@vger.kernel.org
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/20250612091448.41546-1-brgl@bgdev.pl
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2025-06-18 13:56:34 +02:00
..
Kconfig pinctrl: qcom: Introduce SM4250 LPI pinctrl driver 2024-06-26 12:41:07 +02:00
Kconfig.msm pinctrl: qcom: Add test case for TLMM interrupt handling 2025-02-28 09:41:14 +01:00
Makefile pinctrl: qcom: Add test case for TLMM interrupt handling 2025-02-28 09:41:14 +01:00
pinctrl-apq8064.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-apq8084.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-ipq4019.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-ipq5018.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-ipq5332.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-ipq5424.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-ipq6018.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-ipq8064.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-ipq8074.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-ipq9574.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-lpass-lpi.c pinctrl: qcom: lpass-lpi: use new GPIO line value setter callbacks 2025-04-17 09:39:15 +02:00
pinctrl-lpass-lpi.h pinctrl: qcom: lpass-lpi: Remove unused member in struct lpi_pingroup 2023-12-01 14:59:53 +01:00
pinctrl-mdm9607.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-mdm9615.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-msm.c pinctrl: qcom: msm: mark certain pins as invalid for interrupts 2025-06-18 13:56:34 +02:00
pinctrl-msm.h pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-msm8x74.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-msm8226.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-msm8660.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-msm8909.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-msm8916.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-msm8917.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-msm8953.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-msm8960.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-msm8976.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-msm8994.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-msm8996.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-msm8998.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-qcm2290.c pinctrl: qcom: pinctrl-qcm2290: Add missing pins 2025-06-09 10:16:45 +02:00
pinctrl-qcs404.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-qcs615.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-qcs8300.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-qdf2xxx.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-qdu1000.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sa8775p.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sar2130p.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sc7180.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sc7280-lpass-lpi.c pinctrl: Switch back to struct platform_driver::remove() 2024-10-11 21:45:47 +02:00
pinctrl-sc7280.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sc8180x.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sc8280xp-lpass-lpi.c pinctrl: Switch back to struct platform_driver::remove() 2024-10-11 21:45:47 +02:00
pinctrl-sc8280xp.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sdm660.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sdm670.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sdm845.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sdx55.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sdx65.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sdx75.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sm4250-lpass-lpi.c pinctrl: Switch back to struct platform_driver::remove() 2024-10-11 21:45:47 +02:00
pinctrl-sm4450.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sm6115-lpass-lpi.c pinctrl: Switch back to struct platform_driver::remove() 2024-10-11 21:45:47 +02:00
pinctrl-sm6115.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sm6125.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sm6350.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sm6375.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sm7150.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sm8150.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sm8250-lpass-lpi.c pinctrl: Switch back to struct platform_driver::remove() 2024-10-11 21:45:47 +02:00
pinctrl-sm8250.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sm8350-lpass-lpi.c pinctrl: Switch back to struct platform_driver::remove() 2024-10-11 21:45:47 +02:00
pinctrl-sm8350.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sm8450-lpass-lpi.c pinctrl: Switch back to struct platform_driver::remove() 2024-10-11 21:45:47 +02:00
pinctrl-sm8450.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sm8550-lpass-lpi.c pinctrl: Switch back to struct platform_driver::remove() 2024-10-11 21:45:47 +02:00
pinctrl-sm8550.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sm8650-lpass-lpi.c pinctrl: Switch back to struct platform_driver::remove() 2024-10-11 21:45:47 +02:00
pinctrl-sm8650.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-sm8750.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
pinctrl-spmi-gpio.c pinctrl: qcom: spmi-gpio: use new GPIO line value setter callbacks 2025-04-17 09:39:15 +02:00
pinctrl-spmi-mpp.c pinctrl: qcom: spmi-mpp: use new GPIO line value setter callbacks 2025-04-17 09:39:15 +02:00
pinctrl-ssbi-gpio.c pinctrl: qcom: ssbi-gpio: use new GPIO line value setter callbacks 2025-04-17 09:39:15 +02:00
pinctrl-ssbi-mpp.c pinctrl: qcom: ssbi-mpp: use new GPIO line value setter callbacks 2025-04-17 09:39:15 +02:00
pinctrl-x1e80100.c pinctrl: qcom: switch to devm_gpiochip_add_data() 2025-06-09 10:16:45 +02:00
tlmm-test.c pinctrl: qcom: tlmm-test: Fix potential null dereference in tlmm kunit test 2025-04-15 09:23:07 +02:00