Eric Dumazet fd32f1eee6 ipv6: remove nexthop_fib6_nh_bh() ... commit ef1148d448 upstream. After blamed commit, nexthop_fib6_nh_bh() and nexthop_fib6_nh() are the same. Delete nexthop_fib6_nh_bh(), and convert /proc/net/ipv6_route to standard rcu to avoid this splat: [ 5723.180080] WARNING: suspicious RCU usage [ 5723.180083] ----------------------------- [ 5723.180084] include/net/nexthop.h:516 suspicious rcu_dereference_check() usage! [ 5723.180086] other info that might help us debug this: [ 5723.180087] rcu_scheduler_active = 2, debug_locks = 1 [ 5723.180089] 2 locks held by cat/55856: [ 5723.180091] #0: ffff9440a582afa8 (&p->lock){+.+.}-{3:3}, at: seq_read_iter (fs/seq_file.c:188) [ 5723.180100] #1: ffffffffaac07040 (rcu_read_lock_bh){....}-{1:2}, at: rcu_lock_acquire (include/linux/rcupdate.h:326) [ 5723.180109] stack backtrace: [ 5723.180111] CPU: 14 PID: 55856 Comm: cat Tainted: G S I 6.3.0-dbx-DEV #528 [ 5723.180115] Call Trace: [ 5723.180117] <TASK> [ 5723.180119] dump_stack_lvl (lib/dump_stack.c:107) [ 5723.180124] dump_stack (lib/dump_stack.c:114) [ 5723.180126] lockdep_rcu_suspicious (include/linux/context_tracking.h:122) [ 5723.180132] ipv6_route_seq_show (include/net/nexthop.h:?) [ 5723.180135] ? ipv6_route_seq_next (net/ipv6/ip6_fib.c:2605) [ 5723.180140] seq_read_iter (fs/seq_file.c:272) [ 5723.180145] seq_read (fs/seq_file.c:163) [ 5723.180151] proc_reg_read (fs/proc/inode.c:316 fs/proc/inode.c:328) [ 5723.180155] vfs_read (fs/read_write.c:468) [ 5723.180160] ? up_read (kernel/locking/rwsem.c:1617) [ 5723.180164] ksys_read (fs/read_write.c:613) [ 5723.180168] __x64_sys_read (fs/read_write.c:621) [ 5723.180170] do_syscall_64 (arch/x86/entry/common.c:?) [ 5723.180174] entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:120) [ 5723.180177] RIP: 0033:0x7fa455677d2a Fixes: 09eed1192c ("neighbour: switch to standard rcu, instead of rcu_bh") Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: David Ahern <dsahern@kernel.org> Link: https://lore.kernel.org/r/20230510154646.370659-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-10-10 22:00:46 +02:00
..
acpi	ACPI: sleep: Avoid breaking S3 wakeup due to might_sleep()	2023-06-28 11:12:22 +02:00
asm-generic	word-at-a-time: use the same return type for has_zero regardless of endianness	2023-08-11 12:08:11 +02:00
clocksource	…
crypto	crypto: api - Use work queue in crypto_destroy_instance	2023-09-13 09:42:32 +02:00
drm	drm/display/dp: Fix the DP DSC Receiver cap size	2023-08-30 16:11:09 +02:00
dt-bindings	dt-bindings: clock: qcom,gcc-sc8280xp: Add missing GDSCs	2023-09-13 09:42:45 +02:00
keys	…
kunit	…
kvm	KVM: arm64: vgic-v4: Make the doorbell request robust w.r.t preemption	2023-08-23 17:52:28 +02:00
linux	netfilter: handle the connecting collision properly in nf_conntrack_proto_sctp	2023-10-10 22:00:43 +02:00
math-emu	…
media	media: cec: core: add adap_unconfigured() callback	2023-09-13 09:42:54 +02:00
memory	…
misc	…
net	ipv6: remove nexthop_fib6_nh_bh()	2023-10-10 22:00:46 +02:00
pcmcia	…
ras	…
rdma	RDMA/cma: Always set static rate to 0 for RoCE	2023-06-21 16:00:59 +02:00
rv	…
scsi	scsi: Do not attempt to rescan suspended devices	2023-10-10 22:00:35 +02:00
soc	net: mscc: ocelot: don't keep PTP configuration of all ports in single structure	2023-07-19 16:22:01 +02:00
sound	ASoC: Intel: avs: Account for UID of ACPI device	2023-06-21 16:00:53 +02:00
target	…
trace	ipv6: Remove in6addr_any alternatives.	2023-09-19 12:28:10 +02:00
uapi	netlink: split up copies in the ack construction	2023-10-10 22:00:44 +02:00
ufs	…
vdso	…
video	…
xen	…